adding psalm linting

fine tuning of git files

restoring tests

fixes tests after refactoring

fine tuning for psalm baseline

1 files changed, 19 insertions, 17 deletions

diff --git a/src/controllers/IntroController.php b/src/controllers/IntroController.php
index 5f3e9420..baf2d912 100644
--- a/src/controllers/IntroController.php
+++ b/src/controllers/IntroController.php
@@ -1,15 +1,16 @@
 <?php
 
+// declare(strict_types=1);
+
 /**
- * PHPPgAdmin v6.0.0-RC9
+ * PHPPgAdmin vv6.0.0-RC8-16-g13de173f
+ *
  */
 
 namespace PHPPgAdmin\Controller;
 
 /**
  * Base controller class.
- *
- * @package PHPPgAdmin
  */
 class IntroController extends BaseController
 {
@@ -44,48 +45,49 @@ class IntroController extends BaseController
 
         $intro_html .= $this->printTabs('root', 'intro', false);
 
-        $intro_html .= '<h1 style="margin-top:2em">'.$this->appName.' '.$this->appVersion.'</h1>';
-        $intro_html .= '<h3>(PHP '.PHP_VERSION.')</h3>';
+        $intro_html .= '<h1 style="margin-top:2em">' . $this->appName . ' ' . $this->appVersion . '</h1>';
+        $intro_html .= '<h3>(PHP ' . \PHP_VERSION . ')</h3>';
 
         $intro_html .= '<form method="get" action="intro">';
         $intro_html .= '<table>';
         $intro_html .= '<tr class="data1">';
-        $intro_html .= '<th class="data">'.$this->lang['strlanguage'].'</th>';
+        $intro_html .= '<th class="data">' . $this->lang['strlanguage'] . '</th>';
         $intro_html .= '<td>';
         $intro_html .= '<select name="language" onchange="this.form.submit()">';
 
-        $language = isset($_SESSION['webdbLanguage']) ? $_SESSION['webdbLanguage'] : 'english';
+        $language = $_SESSION['webdbLanguage'] ?? 'english';
+
         foreach ($this->appLangFiles as $k => $v) {
-            $selected = ($k == $language) ? ' selected="selected"' : '';
-            $intro_html .= "\t<option value=\"{$k}\"".$selected.">{$v}</option>".PHP_EOL;
+            $selected = ($k === $language) ? ' selected="selected"' : '';
+            $intro_html .= "\t<option value=\"{$k}\"" . $selected . ">{$v}</option>" . \PHP_EOL;
         }
 
         $intro_html .= '</select>';
         $intro_html .= '</td>';
         $intro_html .= '</tr>';
         $intro_html .= '<tr class="data2">';
-        $intro_html .= '<th class="data">'.$this->lang['strtheme'].'</th>';
+        $intro_html .= '<th class="data">' . $this->lang['strtheme'] . '</th>';
         $intro_html .= '<td>';
         $intro_html .= '<select name="theme" onchange="this.form.submit()">';
 
         foreach ($this->appThemes as $k => $v) {
-            $selected = ($k == $this->conf['theme']) ? ' selected="selected"' : '';
-            $intro_html .= "\t<option value=\"{$k}\"".$selected.">{$v}</option>".PHP_EOL;
+            $selected = ($k === $this->conf['theme']) ? ' selected="selected"' : '';
+            $intro_html .= "\t<option value=\"{$k}\"" . $selected . ">{$v}</option>" . \PHP_EOL;
         }
 
         $intro_html .= '</select>';
         $intro_html .= '</td>';
         $intro_html .= '</tr>';
         $intro_html .= '</table>';
-        $intro_html .= '<noscript><p><input type="submit" value="'.$this->lang['stralter'].'" /></p></noscript>';
+        $intro_html .= '<noscript><p><input type="submit" value="' . $this->lang['stralter'] . '" /></p></noscript>';
         $intro_html .= '</form>';
 
-        $intro_html .= '<p>'.$this->lang['strintro'].'</p>';
+        $intro_html .= '<p>' . $this->lang['strintro'] . '</p>';
 
         $intro_html .= '<ul class="intro">';
-        $intro_html .= '	<li><a href="https://github.com/HuasoFoundries/phpPgAdmin6">'.$this->lang['strppahome'].'</a></li>';
-        $intro_html .= '<li><a href="'.$this->lang['strpgsqlhome_url'].'">'.$this->lang['strpgsqlhome'].'</a></li>';
-        $intro_html .= '<li><a href="https://github.com/HuasoFoundries/phpPgAdmin6/issues">'.$this->lang['strreportbug'].'</a></li>';
+        $intro_html .= '	<li><a href="https://github.com/HuasoFoundries/phpPgAdmin6">' . $this->lang['strppahome'] . '</a></li>';
+        $intro_html .= '<li><a href="' . $this->lang['strpgsqlhome_url'] . '">' . $this->lang['strpgsqlhome'] . '</a></li>';
+        $intro_html .= '<li><a href="https://github.com/HuasoFoundries/phpPgAdmin6/issues">' . $this->lang['strreportbug'] . '</a></li>';
         //$intro_html .= '<li><a href="' . $this->lang['strviewfaq_url'] . '">' . $this->lang['strviewfaq'] . '</a></li>';
         $intro_html .= '</ul>';