diff options
| author | Felipe Figueroa <amenadiel@gmail.com> | 2018-05-22 18:51:32 +0300 |
|---|---|---|
| committer | Felipe Figueroa <amenadiel@gmail.com> | 2018-05-22 18:51:32 +0300 |
| commit | 1d12a6325d6d02552c39faec273956e2fe19212c (patch) | |
| tree | e8938c8305dd5bd08629889ffd5216ddd3c626a5 /src/controllers/PrivilegesController.php | |
| parent | 4b8bf36517749138d7ce4f27a34573e86d39dd62 (diff) | |
scrutinizer fixes
Diffstat (limited to 'src/controllers/PrivilegesController.php')
| -rw-r--r-- | src/controllers/PrivilegesController.php | 24 |
1 files changed, 12 insertions, 12 deletions
diff --git a/src/controllers/PrivilegesController.php b/src/controllers/PrivilegesController.php index e3513101..b601b470 100644 --- a/src/controllers/PrivilegesController.php +++ b/src/controllers/PrivilegesController.php @@ -74,8 +74,8 @@ class PrivilegesController extends BaseController $this->printMsg($msg); // Determine whether object should be ref'd by name or oid. - if (isset($_REQUEST[$_REQUEST['subject'] . '_oid'])) { - $object = $_REQUEST[$_REQUEST['subject'] . '_oid']; + if (isset($_REQUEST[$_REQUEST['subject'].'_oid'])) { + $object = $_REQUEST[$_REQUEST['subject'].'_oid']; } else { $object = $_REQUEST[$_REQUEST['subject']]; } @@ -180,7 +180,7 @@ class PrivilegesController extends BaseController $object = $_REQUEST[$_REQUEST['subject']]; if ('function' == $_REQUEST['subject']) { - $objectoid = $_REQUEST[$_REQUEST['subject'] . '_oid']; + $objectoid = $_REQUEST[$_REQUEST['subject'].'_oid']; $urlvars = [ 'action' => 'alter', 'server' => $_REQUEST['server'], @@ -263,9 +263,9 @@ class PrivilegesController extends BaseController /** * Grant permissions on an object to a user. * - * @param boolean $confirm To show entry screen - * @param string $mode 'grant' or 'revoke' - * @param string $msg (optional) A message to show + * @param bool $confirm To show entry screen + * @param string $mode 'grant' or 'revoke' + * @param string $msg (optional) A message to show */ public function doAlter($confirm, $mode, $msg = '') { @@ -297,7 +297,7 @@ class PrivilegesController extends BaseController } $this->printMsg($msg); - echo '<form action="' . \SUBFOLDER . "/src/views/privileges\" method=\"post\">\n"; + echo '<form action="'.\SUBFOLDER."/src/views/privileges\" method=\"post\">\n"; echo "<table>\n"; echo "<tr><th class=\"data left\">{$this->lang['strusers']}</th>\n"; echo '<td class="data1"><select name="username[]" multiple="multiple" size="', min(6, $users->recordCount()), "\">\n"; @@ -351,9 +351,9 @@ class PrivilegesController extends BaseController echo "<p><input type=\"hidden\" name=\"action\" value=\"save\" />\n"; echo '<input type="hidden" name="mode" value="', htmlspecialchars($mode), "\" />\n"; echo '<input type="hidden" name="subject" value="', htmlspecialchars($_REQUEST['subject']), "\" />\n"; - if (isset($_REQUEST[$_REQUEST['subject'] . '_oid'])) { - echo '<input type="hidden" name="', htmlspecialchars($_REQUEST['subject'] . '_oid'), - '" value="', htmlspecialchars($_REQUEST[$_REQUEST['subject'] . '_oid']), "\" />\n"; + if (isset($_REQUEST[$_REQUEST['subject'].'_oid'])) { + echo '<input type="hidden" name="', htmlspecialchars($_REQUEST['subject'].'_oid'), + '" value="', htmlspecialchars($_REQUEST[$_REQUEST['subject'].'_oid']), "\" />\n"; } echo '<input type="hidden" name="', htmlspecialchars($_REQUEST['subject']), @@ -374,8 +374,8 @@ class PrivilegesController extends BaseController echo "</form>\n"; } else { // Determine whether object should be ref'd by name or oid. - if (isset($_REQUEST[$_REQUEST['subject'] . '_oid'])) { - $object = $_REQUEST[$_REQUEST['subject'] . '_oid']; + if (isset($_REQUEST[$_REQUEST['subject'].'_oid'])) { + $object = $_REQUEST[$_REQUEST['subject'].'_oid']; } else { $object = $_REQUEST[$_REQUEST['subject']]; } |