diff options
| author | IcyTv <michael.finger@icytv.de> | 2022-03-07 20:50:19 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-03-07 20:50:19 +0300 |
| commit | 98dce6ca187004189ad0828e778a45b6dcf24dce (patch) | |
| tree | 434454b1fbaf9ce0968f1fca36460dca15bb5db6 /kokoro | |
| parent | 920156cf183baa11f6b65d159da6fba9fdab684e (diff) | |
Fixed Bazel Windows build (#4736)
* Fixed Bazel Windows build
Before this commit, the bazel build setup would not work on windows.
This is due to the fact, that genrule tries to use bash, which fails.
One fix would be to use bazel-skylib's run_binary.
This however does not work (easily) since genrules is more complex.
To (temporarily) fix the windows build, I added the `cmd_bat` property to every genrule.
This seems more like a hack, because it basically repeat commands,
but for now it at least builds on windows.
* Removed BAZEL_SH from bazel presubmit build script
Thanks to @s-perron for pointing out, that the presubmit script uses the msys64 bash shell for the bazel build.
Since adding the `cmd_bat` argument removes the dependency on bash, this is no longer needed.
Diffstat (limited to 'kokoro')
| -rw-r--r-- | kokoro/windows-msvc-2015-release-bazel/build.bat | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/kokoro/windows-msvc-2015-release-bazel/build.bat b/kokoro/windows-msvc-2015-release-bazel/build.bat index b85b5b48e..de20b0aa2 100644 --- a/kokoro/windows-msvc-2015-release-bazel/build.bat +++ b/kokoro/windows-msvc-2015-release-bazel/build.bat @@ -37,7 +37,6 @@ unzip -q bazel-5.0.0-windows-x86_64.zip call "C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\vcvarsall.bat" x64 set BAZEL_VS=C:\Program Files (x86)\Microsoft Visual Studio 14.0 set BAZEL_VC=C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC -set BAZEL_SH=c:\tools\msys64\usr\bin\bash.exe set BAZEL_PYTHON=c:\tools\python2\python.exe :: ######################################### |