API: Check client existence

#3706

1 files changed, 6 insertions, 0 deletions

diff --git a/web/service/inbound.go b/web/service/inbound.go
index 8ab5e6a8..74b44b99 100644
--- a/web/service/inbound.go
+++ b/web/service/inbound.go
@@ -979,10 +979,12 @@ func (s *InboundService) DelInboundClient(inboundId int, clientId string) (bool,
 	interfaceClients := settings["clients"].([]any)
 	var newClients []any
 	needApiDel := false
+	clientFound := false
 	for _, client := range interfaceClients {
 		c := client.(map[string]any)
 		c_id := c[client_key].(string)
 		if c_id == clientId {
+			clientFound = true
 			email, _ = c["email"].(string)
 			needApiDel, _ = c["enable"].(bool)
 		} else {
@@ -990,6 +992,10 @@ func (s *InboundService) DelInboundClient(inboundId int, clientId string) (bool,
 		}
 	}
 
+	if !clientFound {
+		return false, common.NewError("Client Not Found In Inbound For ID:", clientId)
+	}
+
 	if len(newClients) == 0 {
 		return false, common.NewError("no client remained in Inbound")
 	}