diff options
| author | Ilya Shipitsin <chipitsine@gmail.com> | 2016-04-29 22:26:58 +0300 |
|---|---|---|
| committer | Ilya Shipitsin <chipitsine@gmail.com> | 2016-04-29 22:26:58 +0300 |
| commit | d1ea47eb66e87a25d821a81af780ca30c0963929 (patch) | |
| tree | 265ee6cb4240ad2b00a5b7c18eff6841567bdfe6 | |
| parent | 29f93371c3d1917522dc4db074188d9ac2be30f8 (diff) | |
cppcheck issues:
[src/Cedar/Client.c:2184] -> [src/Cedar/Client.c:2187]: (warning) Either the condition 'rpc==0' is redundant or there is possible null pointer dereference: rpc.
[src/Cedar/Client.c:6032] -> [src/Cedar/Client.c:6035]: (warning) Either the condition 'ret!=0' is redundant or there is possible null pointer dereference: ret.
| -rw-r--r-- | src/Cedar/Client.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/Cedar/Client.c b/src/Cedar/Client.c index d4dd39be..00baa32b 100644 --- a/src/Cedar/Client.c +++ b/src/Cedar/Client.c @@ -2181,13 +2181,13 @@ BUF *CiAccountToCfg(RPC_CLIENT_CREATE_ACCOUNT *t) // RPC dispatch routine
PACK *CiRpcDispatch(RPC *rpc, char *name, PACK *p)
{
- CLIENT *c = rpc->Param;
PACK *ret;
// Validate arguments
if (rpc == NULL || name == NULL || p == NULL)
{
return NULL;
}
+ CLIENT *c = rpc->Param;
ret = NewPack();
@@ -6029,11 +6029,11 @@ L_TRY: ReleaseSock(s);
ret = ZeroMalloc(sizeof(REMOTE_CLIENT));
- ret->Rpc = rpc;
rpc->Param = ret;
if (ret != NULL)
{
+ ret->Rpc = rpc;
RPC_CLIENT_VERSION t;
Zero(&t, sizeof(t));
CcGetClientVersion(ret, &t);
|