Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/bareos/bareos.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndreas Rogge <andreas.rogge@bareos.com>2022-09-27 11:31:01 +0300
committerAndreas Rogge <andreas.rogge@bareos.com>2022-11-07 19:37:27 +0300
commit990970bcd1ccd8ecaa62f6c3dd2fc6166065efce (patch)
treee2476541fa5ad2c763bd1c777ae502f742f5b0f0
parent51b66ce8d63975837adfde95c406efc14e0bedd6 (diff)
stored: remove FlushDevice() from backends
remove the unused FlushDevice() function from the backend interface and all interfaces.
-rw-r--r--core/src/stored/backends/droplet_device.cc1
-rw-r--r--core/src/stored/backends/gfapi_device.cc1
-rw-r--r--core/src/stored/backends/unix_fifo_device.cc1
-rw-r--r--core/src/stored/backends/unix_tape_device.cc3
-rw-r--r--core/src/stored/sd_backends.cc2
-rw-r--r--core/src/stored/sd_backends.h3
6 files changed, 2 insertions, 9 deletions
diff --git a/core/src/stored/backends/droplet_device.cc b/core/src/stored/backends/droplet_device.cc
index 6bf1923a0..68d4e0182 100644
--- a/core/src/stored/backends/droplet_device.cc
+++ b/core/src/stored/backends/droplet_device.cc
@@ -1040,7 +1040,6 @@ class Backend : public BackendInterface {
return nullptr;
}
}
- void FlushDevice(void) override {}
};
#ifdef HAVE_DYNAMIC_SD_BACKENDS
diff --git a/core/src/stored/backends/gfapi_device.cc b/core/src/stored/backends/gfapi_device.cc
index b2a74a1b7..214754074 100644
--- a/core/src/stored/backends/gfapi_device.cc
+++ b/core/src/stored/backends/gfapi_device.cc
@@ -588,7 +588,6 @@ class Backend : public BackendInterface {
return nullptr;
}
}
- void FlushDevice(void) override {}
};
# ifdef HAVE_DYNAMIC_SD_BACKENDS
diff --git a/core/src/stored/backends/unix_fifo_device.cc b/core/src/stored/backends/unix_fifo_device.cc
index 60e8a7ef3..c2927d429 100644
--- a/core/src/stored/backends/unix_fifo_device.cc
+++ b/core/src/stored/backends/unix_fifo_device.cc
@@ -328,7 +328,6 @@ class Backend : public BackendInterface {
return nullptr;
}
}
- void FlushDevice(void) override {}
};
#ifdef HAVE_DYNAMIC_SD_BACKENDS
diff --git a/core/src/stored/backends/unix_tape_device.cc b/core/src/stored/backends/unix_tape_device.cc
index 042443470..e0cfb8844 100644
--- a/core/src/stored/backends/unix_tape_device.cc
+++ b/core/src/stored/backends/unix_tape_device.cc
@@ -3,7 +3,7 @@
Copyright (C) 2000-2012 Free Software Foundation Europe e.V.
Copyright (C) 2013-2013 Planets Communications B.V.
- Copyright (C) 2013-2020 Bareos GmbH & Co. KG
+ Copyright (C) 2013-2022 Bareos GmbH & Co. KG
This program is Free Software; you can redistribute it and/or
modify it under the terms of version three of the GNU Affero General Public
@@ -72,7 +72,6 @@ class Backend : public BackendInterface {
return nullptr;
}
}
- void FlushDevice(void) override {}
};
#ifdef HAVE_DYNAMIC_SD_BACKENDS
diff --git a/core/src/stored/sd_backends.cc b/core/src/stored/sd_backends.cc
index 0c3916b25..8351804b1 100644
--- a/core/src/stored/sd_backends.cc
+++ b/core/src/stored/sd_backends.cc
@@ -61,7 +61,6 @@ struct BackendDeviceLibraryDescriptor {
~BackendDeviceLibraryDescriptor()
{
- FlushDevice();
delete backend_interface;
dlclose(dynamic_library_handle);
}
@@ -90,7 +89,6 @@ struct BackendDeviceLibraryDescriptor {
{
return backend_interface->GetDevice(jcr, device_type);
}
- void FlushDevice() { backend_interface->FlushDevice(); }
};
const std::map<DeviceType, const char*> device_type_to_name_mapping
diff --git a/core/src/stored/sd_backends.h b/core/src/stored/sd_backends.h
index 9ba9840b1..b61ff4a7e 100644
--- a/core/src/stored/sd_backends.h
+++ b/core/src/stored/sd_backends.h
@@ -32,9 +32,8 @@ namespace storagedaemon {
class BackendInterface {
public:
- virtual ~BackendInterface() {}
+ virtual ~BackendInterface() = default;
virtual Device* GetDevice(JobControlRecord* jcr, DeviceType device_type) = 0;
- virtual void FlushDevice(void) = 0;
};