diff options
| author | Martin Schulze <37703201+martin-schulze-vireso@users.noreply.github.com> | 2023-01-07 02:09:30 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-01-07 02:09:30 +0300 |
| commit | db015db5edfd788301d42eda0348301d9893a3b8 (patch) | |
| tree | c1a7a84ce93eaa7ef42d8e29245b8a80e708c90c | |
| parent | 78fa631d1370562d2cd4a1390989e706158e7bf0 (diff) | |
| parent | 51f5fd7b4bb048b4c850566ec0e94185e027b881 (diff) | |
Merge pull request #54 from bats-core/fix/issue-53-assert_regex-deems-regex-matching-empty-string-as-invalid
assert_regex: matching empty string is not invalid regex
| -rw-r--r-- | src/assert_regex.bash | 2 | ||||
| -rw-r--r-- | test/assert_regex.bats | 5 |
2 files changed, 6 insertions, 1 deletions
diff --git a/src/assert_regex.bash b/src/assert_regex.bash index 636318e..17a7057 100644 --- a/src/assert_regex.bash +++ b/src/assert_regex.bash @@ -36,7 +36,7 @@ assert_regex() { local -r value="${1}" local -r pattern="${2}" - if [[ '' =~ ${pattern} ]] || (( ${?} == 2 )); then + if [[ '' =~ ${pattern} ]]; (( ${?} == 2 )); then echo "Invalid extended regular expression: \`${pattern}'" \ | batslib_decorate 'ERROR: assert_regex' \ | fail diff --git a/test/assert_regex.bats b/test/assert_regex.bats index ef9c3a8..0a9c902 100644 --- a/test/assert_regex.bats +++ b/test/assert_regex.bats @@ -80,3 +80,8 @@ Invalid extended regular expression: `[.*' -- ERR_MSG } + +@test "assert_regex allows regex matching empty string (see #53)" { + run assert_regex any_value '.*' + assert_success +} |