diff options
| author | Jim Brandt <jbrandt@bestpractical.com> | 2022-08-05 22:59:08 +0300 |
|---|---|---|
| committer | Jim Brandt <jbrandt@bestpractical.com> | 2022-08-05 22:59:08 +0300 |
| commit | 2867592b3fd43c9127d57a1d9ac4093df20f1dd3 (patch) | |
| tree | e8b6783fb4955a8b02122191814ba786009a62d8 | |
| parent | a1f8abad86c5ad49d85be70075d4138d35e39ff7 (diff) | |
Restore always flag so we get time info on failures
4561ec7e removed an if:always() as a noop, but the default
behavior is to apply a success() check, which is false if
a previous step failed. For the timer, we want to see the
time even on failure, so restore the always() conditional.
https://docs.github.com/en/actions/learn-github-actions/expressions#status-check-functions
| -rw-r--r-- | .github/workflows/github-action.yml | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/.github/workflows/github-action.yml b/.github/workflows/github-action.yml index 2da2cc428a..e13bd3fcaf 100644 --- a/.github/workflows/github-action.yml +++ b/.github/workflows/github-action.yml @@ -31,6 +31,8 @@ jobs: shell: bash run: docker exec rt bash -c "cd /rt && RT_TEST_PARALLEL_NUM=5 make test-parallel" - name: Get run time + # Default is success(), we want to always() get the time + if: always() shell: bash run: | export RT_GA_END_TIME=$(date +%s) @@ -83,6 +85,7 @@ jobs: shell: bash run: docker exec rt bash -c "cd /rt && RT_TEST_PARALLEL_NUM=5 make test-parallel" - name: Get run time + if: always() shell: bash run: | export RT_GA_END_TIME=$(date +%s) @@ -136,6 +139,7 @@ jobs: shell: bash run: docker exec -e RT_DBA_USER=postgres -e RT_TEST_WEB_HANDLER=apache+fcgid -e HTTPD_ROOT=/etc/apache2 -e RT_TEST_APACHE=/usr/sbin/apache2 -e RT_TEST_APACHE_MODULES=/usr/lib/apache2/modules -u rt-user rt bash -c "cd /rt && RT_TEST_PARALLEL_NUM=5 make test-parallel" - name: Get run time + if: always() shell: bash run: | export RT_GA_END_TIME=$(date +%s) |