diff options
| author | Brad Warren <bmw@users.noreply.github.com> | 2022-02-24 02:10:48 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-02-24 02:10:48 +0300 |
| commit | e2b7b62b9897e2696491f6186236e0a0b762423b (patch) | |
| tree | e39d57d588758c543931f4383b837ca6d3333601 /.azure-pipelines | |
| parent | 5e76669c5026732d1440e39e93b58220ef7bd354 (diff) | |
remove test_sdists.sh (#9213)
The reason I want to do this is many of the targets of `test_sdists.sh` use Python 3.6 which [has reached its EOL](https://www.python.org/dev/peps/pep-0494/#lifespan). We could instead just stop running the test on these systems or install a newer version of Python 3 outside of OS packaging, but instead I decided to look into why we have these tests to begin with.
I introduced these tests many years ago in https://github.com/certbot/certbot/pull/4089 as a fix for https://github.com/certbot/certbot/issues/4044. Essentially the problem was the way packagers ran tests and the way we ran tests were slightly different. This difference could cause test failures when distros tried to run tests on our packages.
Since I did this, [we've switched to telling packagers to run tests using `pytest` like we do](https://github.com/certbot/certbot/blob/5e76669c5026732d1440e39e93b58220ef7bd354/certbot/docs/packaging.rst#notes-for-package-maintainers) and we've greatly reduced our reliance on OS packaging through things like `snap`.
Because of this, I think we should stop running this test, reducing our reliance on the heavy "test farm tests", and simplifying our CI pipeline. I think future problems here is quite unlikely and even if we have them, it should only affect tests on our non-primary distribution mechanisms which I think is a very minor concern.
When reviewing this PR, it's probably worth noting that I just replaced `targets.yaml` with the contents of `apache2_targets.yaml` since the Apache 2 tests are the only runs we're running with this change.
Diffstat (limited to '.azure-pipelines')
| -rw-r--r-- | .azure-pipelines/templates/jobs/extended-tests-jobs.yml | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/.azure-pipelines/templates/jobs/extended-tests-jobs.yml b/.azure-pipelines/templates/jobs/extended-tests-jobs.yml index e10f2790e..31325ae6c 100644 --- a/.azure-pipelines/templates/jobs/extended-tests-jobs.yml +++ b/.azure-pipelines/templates/jobs/extended-tests-jobs.yml @@ -65,15 +65,9 @@ jobs: le-modification: IMAGE_NAME: ubuntu-18.04 TOXENV: modification - macos-farmtest-apache2: - # We run one of these test farm tests on macOS to help ensure the - # tests continue to work on the platform. - IMAGE_NAME: macOS-10.15 + farmtest-apache2: PYTHON_VERSION: 3.8 TOXENV: test-farm-apache2 - farmtest-sdists: - PYTHON_VERSION: 3.7 - TOXENV: test-farm-sdists pool: vmImage: $(IMAGE_NAME) steps: |