diff options
| author | Brad Warren <bmw@users.noreply.github.com> | 2022-08-17 02:01:51 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-08-17 02:01:51 +0300 |
| commit | cb632c376f17dfd75306020a17248f3c33c1ab2f (patch) | |
| tree | 78b8dce30d83ee72e6178ea2c080ba4884300faf | |
| parent | 94bbb4c44c20bb71cf743b8de4652ab2bdea93c1 (diff) | |
encourage words before code (#9377)
| -rw-r--r-- | .github/pull_request_template.md | 1 | ||||
| -rw-r--r-- | certbot/docs/contributing.rst | 3 |
2 files changed, 4 insertions, 0 deletions
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 53298291b..1d8b498ac 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,5 +1,6 @@ ## Pull Request Checklist +- [ ] The Certbot team has recently expressed interest in reviewing a PR for this. If not, this PR may be closed due our limited resources and need to prioritize how we spend them. - [ ] If the change being made is to a [distributed component](https://certbot.eff.org/docs/contributing.html#code-components-and-layout), edit the `master` section of `certbot/CHANGELOG.md` to include a description of the change being made. - [ ] Add or update any documentation as needed to support the changes in this PR. - [ ] Include your name in `AUTHORS.md` if you like. diff --git a/certbot/docs/contributing.rst b/certbot/docs/contributing.rst index ac8488e08..c32bdc170 100644 --- a/certbot/docs/contributing.rst +++ b/certbot/docs/contributing.rst @@ -500,6 +500,9 @@ Submitting a pull request Steps: +0. We recommend you talk with us in a GitHub issue or :ref:`Mattermost <ask for + help>` before writing a pull request to ensure the changes you're making is + something we have the time and interest to review. 1. Write your code! When doing this, you should add :ref:`mypy type annotations <type annotations>` for any functions you add or modify. You can check that you've done this correctly by running ``tox -e mypy`` on a machine that has |