| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
* Remove deprecation warnings
* update ci
* update setup.py files
* update changelog
* update pinnings
* update requests and friends
* update setuptools pin
* update setuptools pin pt2
* update pytz
* upgrade pyparsing
* upgrade boto deps
* update deps and docs
* update pyproject.toml comment
* remove trailets pin
* remove explicit PYTHON_VERSION
|
|
|
|
|
|
|
|
|
|
* Ignore SOA TTL in favor of explicit TTL argument
`domain.ttl` should be `None` so that the `self.ttl` argument in
`add_txt_record()` is not ignored (`domain.ttl` takes precedence).
* Document mitigation for dns-digitalocean ignoring the 30 second TTL.
|
|
* Add wildcard example
* Update wildcard example
|
|
* Add types in all DNS plugins
* Order imports
* Fix type
* Update certbot-dns-route53/certbot_dns_route53/_internal/dns_route53.py
Co-authored-by: alexzorin <alex@zor.io>
* Clean up imports
Co-authored-by: alexzorin <alex@zor.io>
|
|
|
|
|
|
* Extract from #9084
* Cast/ignore types during the transition
* Fix after review
* Fix lint
|
|
|
|
Fixes https://github.com/certbot/certbot/issues/9058.
The changes to the CI config are equivalent to the ones made in https://github.com/certbot/certbot/pull/8460.
Other than ignoring some warnings raised by botocore, the main additional work that had to be done here was switching away from using `distutils.version.LooseVersion` since the entire `distutils` module was deprecated in Python 3.10. To do that, I took a few different approaches:
* If the version strings being parsed are from Python packages such as Certbot or setuptools, I switched to using [pkg_resources.parse_version](https://setuptools.pypa.io/en/latest/pkg_resources.html#parsing-utilities) from `setuptools`. This functionality has been available since [setuptools 8.0 from 2014](https://setuptools.pypa.io/en/latest/history.html#id865).
* If the version strings being parsed are not from Python packages, I added code equivalent to `distutils.version.LooseVersion` in `certbot.util.parse_loose_version`.
* The code for `CERTBOT_PIP_NO_BINARY` can be completely removed since that variable isn't used or referenced anywhere in this repo.
* add python 3.10 support
* make some version changes
* don't use looseversion in setup.py
* switch to pkg_resources
* deprecate get_strict_version
* fix route53 tests
* remove unused CERTBOT_PIP_NO_BINARY code
* stop using distutils in letstest
* add unit tests
* more changelog entries
|
|
* pin readthedocs deps
* fix reqs path
|
|
|
|
|
|
|
|
|
|
|
|
|
|
This PR removes all zope dependencies from plugins configuration.
It also lets Sphinx upgrade to the next major version by removing the plugin dedicated to zope interfaces documentation. As a consequence, the deprecated zope interfaces are not documented anymore.
* Cleanup zope dependencies in plugins and upgrade sphinx
* Update pinnings
|
|
|
|
|
|
* Implement certbot services
* Various fixes
* Local oldest requirements
* Clean imports
* Add unit tests for certbot.services
* Clean code
* Protect against nullity of global services
* Fix CLI
* Fix tests
* Consistent test behavior
* Define new ABC classes
* Reimplement services with new ABC classes
* Adapt plugins discovery and selection
* Remove zope interfaces from plugins
* Re-enable delegation for simplicity
* Fix interfaces declaration
* Remove interface implementer
* Interfaces ordering
* Extract zope logic from discovery
* Cleanup imports
* Fixing tests
* Fix main_test
* Finish certbot unit tests
* Fix lint
* Various fixes thanks to mypy
* Fix lint
* Order imports
* Various fixes
* Clean code
* Remove reporter service, migrate display service in certbot.display.util.
* Fix test
* Fix apache compatibility test
* Fix oldest test
* Setup certbot.display.service module
* Reintegrate in util
* Fix imports
* Fix tests and documentation
* Refactor
* Cleanup
* Cleanup
* Clean imports
* Add unit tests
* Borrow sphinx build fix from #8863
* Align zope interfaces on ABC
* Various fixes
* Fix type
* Fix type
* Some cleanup
* Fix lint
* Update certbot/certbot/_internal/configuration.py
Co-authored-by: Brad Warren <bmw@users.noreply.github.com>
* Update certbot/certbot/_internal/configuration.py
Co-authored-by: Brad Warren <bmw@users.noreply.github.com>
* Fix imports
* Fix Config contract (accounts_dir property)
* Remove unnecessary interface
* Set NamespaceConfig public, remove Config interface
* Remove Display ABC and implementation of IDisplay
* Clean lint
* Cleanup old decorators
* Contract on plugin constructor only
* Update certbot/certbot/tests/util.py
Co-authored-by: Brad Warren <bmw@users.noreply.github.com>
* Update certbot/certbot/configuration.py
Co-authored-by: Brad Warren <bmw@users.noreply.github.com>
* Update certbot/certbot/interfaces.py
Co-authored-by: Brad Warren <bmw@users.noreply.github.com>
* Some corrections
* Add changelog
* Fix --authenticators and --installers flags on plugins subcommand
* Fix multiheritance on the interface Plugin
* Update certbot/certbot/_internal/plugins/manual.py
Co-authored-by: Brad Warren <bmw@users.noreply.github.com>
* Update certbot/certbot/_internal/plugins/disco.py
Co-authored-by: Brad Warren <bmw@users.noreply.github.com>
* Add warnings in logger also
* Add deprecation warnings also when plugins are verified.
Co-authored-by: Brad Warren <bmw@users.noreply.github.com>
|
|
`certbot.display.util` module (#8835)
* Implement certbot services
* Various fixes
* Local oldest requirements
* Clean imports
* Add unit tests for certbot.services
* Clean code
* Protect against nullity of global services
* Fix CLI
* Fix tests
* Consistent test behavior
* Various fixes
* Clean code
* Remove reporter service, migrate display service in certbot.display.util.
* Fix test
* Fix apache compatibility test
* Fix oldest test
* Setup certbot.display.service module
* Reintegrate in util
* Fix imports
* Fix tests and documentation
* Refactor
* Cleanup
* Cleanup
* Clean imports
* Add unit tests
* Borrow sphinx build fix from #8863
* Fix type
* Add comment
* Do not reuse existing display service, which never exist at that time
* Make get_display() private
* Fix lint
* Make display internal
* Fix circular dependencies
* Fixing circular dependencies
* Rename patch methods and update docstring
* Update deprecation messages
* Update certbot/certbot/_internal/display/obj.py
Co-authored-by: Brad Warren <bmw@users.noreply.github.com>
* Update certbot/certbot/tests/util.py
Co-authored-by: Brad Warren <bmw@users.noreply.github.com>
* Update certbot/certbot/tests/util.py
Co-authored-by: Brad Warren <bmw@users.noreply.github.com>
* Update certbot/certbot/tests/util.py
Co-authored-by: Brad Warren <bmw@users.noreply.github.com>
* Update certbot/certbot/tests/util.py
Co-authored-by: Brad Warren <bmw@users.noreply.github.com>
* Add links
* Avoid relying on internal certbot packages from certbot-apache
* Keep same behavior for patch_get_utility*
* Better diff
* Add changelog
* Update certbot/certbot/tests/util.py
Co-authored-by: Brad Warren <bmw@users.noreply.github.com>
Co-authored-by: Brad Warren <bmw@users.noreply.github.com>
|
|
|
|
|
|
This is part of https://github.com/certbot/certbot/issues/8787. I got a +1 from our packagers at major distros in https://github.com/certbot/certbot/issues/8761.
* remove local-oldest-requirements files
* fix tests
* fix some oldest tests
* list packages on one line in tox.ini
* add changelog entry
|
|
|
|
|
|
Streamline and reorganize Certbot's CLI output.
This change is a substantial command-line UX overhaul,
based on previous user research. The main goal was to streamline
and clarify output. To see more verbose output, use the -v or -vv flags.
---
* nginx,apache: CLI logging changes
- Add "Successfully deployed ..." message using display_util
- Remove IReporter usage and replace with display_util
- Standardize "... could not find a VirtualHost ..." error
This changes also bumps the version of certbot required by certbot-nginx
and certbot-apache to take use of the new display_util function.
* fix certbot_compatibility_test
since the http plugins now require IDisplay, we need to inject it
* fix dependency version on certbot
* use better asserts
* try fix oldest deps
because certbot 1.10.0 depends on acme>=1.8.0, we need to use
acme==1.8.0 in the -oldest tests
* cli: redesign output of new certificate reporting
Changes the output of run, certonly and certonly --csr. No longer uses
IReporter.
* cli: redesign output of failed authz reporting
* fix problem sorting to be stable between py2 & 3
* add some catch-all error text
* cli: dont use IReporter for EFF donation prompt
* add per-authenticator hints
* pass achalls to auth_hint, write some tests
* exclude static auth hints from coverage
* dont call auth_hint unless derived from .Plugin
* dns fallback hint: dont assume --dns-blah works
--dns-blah won't work for third-party plugins, they need to be specified
using --authenticator dns-blah.
* add code comments about the auth_hint interface
* renew: don't restart the installer for dry-runs
Prevents Certbot from superfluously invoking the installer restart
during dry-run renewals. (This does not affect authenticator restarts).
Additionally removes some CLI output that was reporting the fullchain
path of the renewed certificate.
* update CHANGELOG.md
* cli: redesign output when cert installation failed
- Display a message when certificate installation begins.
- Don't use IReporter, just log errors immediately if restart/rollback
fails.
- Prompt the user with a command to retry the installation process once
they have fixed any underlying problems.
* vary by preconfigured_renewal
and move expiry date to be above the renewal advice
* update code comment
Co-authored-by: ohemorange <ebportnoy@gmail.com>
* update code comment
Co-authored-by: ohemorange <ebportnoy@gmail.com>
* fix lint
* derve cert name from cert_path, if possible
* fix type annotation
* text change in nginx hint
Co-authored-by: ohemorange <ebportnoy@gmail.com>
* print message when restarting server after renewal
* log: print "advice" when exiting with an error
When running in non-quiet mode.
* try fix -oldest lock_test.py
* fix docstring
* s/Restarting/Reloading/ when notifying the user
* fix test name
Co-authored-by: ohemorange <ebportnoy@gmail.com>
* type annotations
* s/using the {} plugin/installer: {}/
* copy: avoid "plugin" where possible
* link to user guide#automated-renewals
when not running with --preconfigured-renewal
* cli: reduce default logging verbosity
* fix lock_test: -vv is needed to see logger.debug
* Change comment in log.py to match the change to default verbosity
* Audit and adjust logging levels in apache module
* Audit and adjust logging levels in nginx module
* Audit, adjust logging levels, and improve logging calls in certbot module
* Fix tests to mock correct methods and classes
* typo in non-preconfigured-renewal message
Co-authored-by: ohemorange <ebportnoy@gmail.com>
* fix test
* revert acme version bump
* catch up to python3 changes
* Revert "revert acme version bump"
This reverts commit fa83d6a51cf8d0e7e17da53c6b751ad12945d0cf.
* Change ocsp check error to warning since it's non-fatal
* Update storage_test in parallel with last change
* get rid of leading newline on "Deploying [...]"
* shrink renewal and installation success messages
* print logfile rather than logdir in exit handler
* Decrease logging level to info for idempotent operation where enhancement is already set
* Display cert not yet due for renewal message when renewing and no other action will be taken, and change cert to certificate
* also write to logger so it goes in the log file
* Don't double write to log file; fix main test
* cli: remove trailing newline on new cert reporting
* ignore type error
* revert accidental changes to dependencies
* Pass tests in any timezone by using utcfromtimestamp
* Add changelog entry
* fix nits
* Improve wording of try again message
* minor wording change to changelog
* hooks: send hook stdout to CLI stdout
includes both --manual and --{pre,post,renew} hooks
* update docstrings and remove TODO
* add a pending deprecation on execute_command
* add test coverage for both
* update deprecation text
Co-authored-by: ohemorange <ebportnoy@gmail.com>
Co-authored-by: Alex Zorin <alex@zorin.id.au>
Co-authored-by: alexzorin <alex@zor.io>
|
|
|
