diff options
| author | Kir Kolyshkin <kolyshkin@gmail.com> | 2022-04-13 04:09:49 +0300 |
|---|---|---|
| committer | Andrei Vagin <avagin@gmail.com> | 2022-08-31 01:42:25 +0300 |
| commit | c056f99855db587e2563883c690c55d73439039c (patch) | |
| tree | 6394ca6d850b0a29cbf8ac16080b0b11fcebed8e | |
| parent | 2666eec7bbb34e3d9099a46bf12fd8e6c124179e (diff) | |
ci/gha/lint: install a recent shellcheck
Instead of using shellcheck v0.7.2 from fedora repo,
let's install the latest version (v0.8.0).
This allows to remove some "shellcheck disable=..." annotations,
and (I hope) better checking quality overall.
While at it, remove findutils from dnf install as this package is
already installed.
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
| -rw-r--r-- | .github/workflows/lint.yml | 13 |
1 files changed, 12 insertions, 1 deletions
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index d32403d05..3d42f3dcf 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -9,7 +9,18 @@ jobs: image: registry.fedoraproject.org/fedora:latest steps: - name: Install tools - run: sudo dnf -y install git make python3-flake8 ShellCheck clang-tools-extra which findutils codespell git-clang-format + run: sudo dnf -y install git make python3-flake8 xz clang-tools-extra which codespell git-clang-format + + # TODO: remove this and use ShellCheck from repo once F37 with ShellCheck 0.8.0 is out. + - name: install shellcheck + env: + VERSION: v0.8.0 + BASEURL: https://github.com/koalaman/shellcheck/releases/download + SHA256: f4bce23c11c3919c1b20bcb0f206f6b44c44e26f2bc95f8aa708716095fa0651 + run: | + curl -sSfL --retry 5 $BASEURL/$VERSION/shellcheck-$VERSION.linux.x86_64.tar.xz | + tar xfJ - -C /usr/local/bin --strip 1 shellcheck-$VERSION/shellcheck + sha256sum --strict --check - <<<"$SHA256 /usr/local/bin/shellcheck" - uses: actions/checkout@v2 |