diff options
| author | Dmitry Safonov <dsafonov@virtuozzo.com> | 2017-03-07 15:55:29 +0300 |
|---|---|---|
| committer | Andrei Vagin <avagin@virtuozzo.com> | 2017-03-15 09:36:09 +0300 |
| commit | b502d7fd6b14ab8c006d650398264c8196d44787 (patch) | |
| tree | 2e82daafb306659cb7f3a338eed78f50a7e563f0 /compel/arch/aarch64 | |
| parent | 72557edb1506fcab56a6c1390070c3fbee4cdeb6 (diff) | |
compel: pass regs by pointer in get_task_regs()
CID 73371 (#1 of 1): Big parameter passed by value (PASS_BY_VALUE)
pass_by_value: Passing parameter regs of type user_regs_struct_t
(size 224 bytes) by value.
Suggesting to do this until compel is released and API is cut in stone.
Signed-off-by: Dmitry Safonov <dsafonov@virtuozzo.com>
Signed-off-by: Andrei Vagin <avagin@virtuozzo.com>
Diffstat (limited to 'compel/arch/aarch64')
| -rw-r--r-- | compel/arch/aarch64/src/lib/infect.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/compel/arch/aarch64/src/lib/infect.c b/compel/arch/aarch64/src/lib/infect.c index 4f5534b75..41600e091 100644 --- a/compel/arch/aarch64/src/lib/infect.c +++ b/compel/arch/aarch64/src/lib/infect.c @@ -56,7 +56,7 @@ int sigreturn_prep_fpu_frame_plain(struct rt_sigframe *sigframe, return 0; } -int get_task_regs(pid_t pid, user_regs_struct_t regs, save_regs_t save, void *arg) +int get_task_regs(pid_t pid, user_regs_struct_t *regs, save_regs_t save, void *arg) { struct iovec iov; user_fpregs_struct_t fpsimd; @@ -64,7 +64,7 @@ int get_task_regs(pid_t pid, user_regs_struct_t regs, save_regs_t save, void *ar pr_info("Dumping GP/FPU registers for %d\n", pid); - iov.iov_base = ®s; + iov.iov_base = regs; iov.iov_len = sizeof(user_regs_struct_t); if ((ret = ptrace(PTRACE_GETREGSET, pid, NT_PRSTATUS, &iov))) { pr_perror("Failed to obtain CPU registers for %d", pid); @@ -78,7 +78,7 @@ int get_task_regs(pid_t pid, user_regs_struct_t regs, save_regs_t save, void *ar goto err; } - ret = save(arg, ®s, &fpsimd); + ret = save(arg, regs, &fpsimd); err: return ret; } |