diff options
author | Pavel Emelyanov <xemul@virtuozzo.com> | 2016-08-24 21:12:03 +0300 |
---|---|---|
committer | Pavel Emelyanov <xemul@virtuozzo.com> | 2016-09-06 19:31:21 +0300 |
commit | 6ae4a97309d75cbfec1c5c15b0cd454c1901d3ed (patch) | |
tree | a8cb148a23eb4a2a544b5c4c68f2665813a0934d /images/rpc.proto | |
parent | 0a4b21032c0b1b1bc58973f22ffa4101d8f2ed0e (diff) |
rpc: Report back first error message on failure
When running criu in swrk mode the client typically wants to know
the reason of failure. Right now criu reports back NOTHING but the
fact that dump/restore/etc fails. We've tried to address this by
introducing the cr-errno engine, but it doesn't seem to be informative
enough and is hard to maintain -- adding new errno-s is boring :(
I propose to report back the first message with ERROR level upon
failrure as __typically__ the very first error message indicates
that proceeding is impossible and criu rolls back (generating more
error messages, so it's crucial to know the very first one).
If we ever meet the situation that the first pr_err/pr_perror doesn't
cause criu to exit, this printing should be fixed to be pr_warn.
Signed-off-by: Pavel Emelyanov <xemul@virtuozzo.com>
Acked-by: Andrei Vagin <avagin@virtuozzo.com>
Diffstat (limited to 'images/rpc.proto')
-rw-r--r-- | images/rpc.proto | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/images/rpc.proto b/images/rpc.proto index 11d169bfc..9b36178e8 100644 --- a/images/rpc.proto +++ b/images/rpc.proto @@ -187,4 +187,5 @@ message criu_resp { optional int32 cr_errno = 7; optional criu_features features = 8; + optional string cr_errmsg = 9; } |