Correctly handle missing arguments

1 files changed, 12 insertions, 3 deletions

diff --git a/app/Http/Controllers/Api/ApiLinkController.php b/app/Http/Controllers/Api/ApiLinkController.php
index 03ad8cb..da5b574 100644
--- a/app/Http/Controllers/Api/ApiLinkController.php
+++ b/app/Http/Controllers/Api/ApiLinkController.php
@@ -12,8 +12,12 @@ class ApiLinkController extends ApiController {
         $user = self::getApiUserInfo($request);
 
         /* */
-        $long_url = $request->input('url');
-        $is_secret = ($request->input('is_secret') == 'false' ? false : true);
+        $long_url = $request->input('url'); // * required
+        $is_secret = ($request->input('is_secret') == 'true' ? true : false);
+
+        if (!self::checkRequiredArgs([$long_url])) {
+            abort(400, "Missing required arguments.");
+        }
 
         $link_ip = $request->ip();
         $custom_ending = $request->input('custom_ending');
@@ -29,7 +33,12 @@ class ApiLinkController extends ApiController {
 
         /* */
 
-        $url_ending = $request->input('url_ending');
+        $url_ending = $request->input('url_ending'); // * required
+
+        if (!self::checkRequiredArgs([$url_ending])) {
+            abort(400, "Missing required arguments.");
+        }
+
         // "secret" key required for lookups on secret URLs
         $url_key = $request->input('url_key');