diff options
| author | flaburgan <flaburgan@geexxx.fr> | 2017-10-17 21:46:02 +0300 |
|---|---|---|
| committer | Benjamin Neff <benjamin@coding4coffee.ch> | 2018-01-21 23:29:06 +0300 |
| commit | b156c2f1a343854180549706484f543776301510 (patch) | |
| tree | fe511ab68e6a4105c206c821aaae5027ad97f4b7 | |
| parent | 5a6bd47000de4d67de5b208a6600b0ca779cb6fc (diff) | |
Use `current-password` and `new-password` for password autocomplete
closes #7642
fixes #7633
| -rw-r--r-- | Changelog.md | 1 | ||||
| -rw-r--r-- | app/views/users/_close_account_modal.haml | 3 | ||||
| -rw-r--r-- | app/views/users/_edit.haml | 6 |
3 files changed, 6 insertions, 4 deletions
diff --git a/Changelog.md b/Changelog.md index bb0b21415..690ab76a3 100644 --- a/Changelog.md +++ b/Changelog.md @@ -3,6 +3,7 @@ ## Refactor * Work on the data downloads: Fixed general layout of buttons, added a timestamp and implemented auto-deletion of old exports [#7684](https://github.com/diaspora/diaspora/pull/7684) * Increase Twitter character limit to 280 [#7694](https://github.com/diaspora/diaspora/pull/7694) +* Improve password autocomplete with password managers [#7642](https://github.com/diaspora/diaspora/pull/7642) ## Bug fixes * Fix invite link on the contacts page when the user has now contacts [#7690](https://github.com/diaspora/diaspora/pull/7690) diff --git a/app/views/users/_close_account_modal.haml b/app/views/users/_close_account_modal.haml index 15ef12935..0f95dbe54 100644 --- a/app/views/users/_close_account_modal.haml +++ b/app/views/users/_close_account_modal.haml @@ -34,7 +34,8 @@ = f.error_messages .form-group = f.label :close_account_password, t("users.edit.current_password"), for: :close_account_password - = f.password_field :current_password, id: :close_account_password, class: "form-control" + = f.password_field :current_password, id: :close_account_password, class: "form-control", + autocomplete: "current-password" .modal-footer .btn.btn-default{type: "button", data: {dismiss: "modal"}, aria: {hidden: "true"}} = t("cancel") diff --git a/app/views/users/_edit.haml b/app/views/users/_edit.haml index f0a141514..0ec3102b7 100644 --- a/app/views/users/_edit.haml +++ b/app/views/users/_edit.haml @@ -39,18 +39,18 @@ = f.label :current_password, t(".current_password"), class: "col-sm-6 control-label" .col-sm-6 = f.password_field :current_password, placeholder: t(".current_password_expl"), - class: "form-control" + class: "form-control", autocomplete: "current-password" .form-group = f.label :password, t(".new_password"), class: "col-sm-6 control-label" .col-sm-6 = f.password_field :password, placeholder: t(".character_minimum_expl"), - class: "form-control" + class: "form-control", autocomplete: "new-password" .form-group = f.label :password_confirmation, t("registrations.new.password_confirmation"), class: "col-sm-6 control-label" .col-sm-6 = f.password_field :password_confirmation, placeholder: t(".character_minimum_expl"), - class: "form-control" + class: "form-control", autocomplete: "new-password" .clearfix = f.submit t(".change_password"), class: "btn btn-primary pull-right", name: "change_password" |