don't update updated_at date when read the notifications.

updated_at is displayed in the frontend and should only be updated when
another notification_actor gets added

Also improved the sql-queries: update directly and not select first and
update then.

1 files changed, 5 insertions, 7 deletions

diff --git a/app/services/post_service.rb b/app/services/post_service.rb
index 928375e29..4c3d7a6b5 100644
--- a/app/services/post_service.rb
+++ b/app/services/post_service.rb
@@ -46,15 +46,13 @@ class PostService
   end
 
   def mark_comment_reshare_like_notifications_read(post_id)
-    notifications = Notification.where(recipient_id: user.id, target_type: "Post", target_id: post_id, unread: true)
-    notifications.each do |notification|
-      notification.set_read_state(true)
-    end
+    Notification.where(recipient_id: user.id, target_type: "Post", target_id: post_id, unread: true)
+      .update_all(unread: false)
   end
 
   def mark_mention_notifications_read(post_id)
-    mention = find(post_id).mentions.where(person_id: user.person_id).first
-    Notification.where(recipient_id: user.id, target_type: "Mention", target_id: mention.id, unread: true)
-      .first.try(:set_read_state, true) if mention
+    mention_id = Mention.where(post_id: post_id, person_id: user.person_id).pluck(:id)
+    Notification.where(recipient_id: user.id, target_type: "Mention", target_id: mention_id, unread: true)
+      .update_all(unread: false) if mention_id
   end
 end