remove old Private and Public Receiver

6 files changed, 3 insertions, 263 deletions

diff --git a/spec/integration/attack_vectors_spec.rb b/spec/integration/attack_vectors_spec.rb
index 284823f4e..2dc9dba0f 100644
--- a/spec/integration/attack_vectors_spec.rb
+++ b/spec/integration/attack_vectors_spec.rb
@@ -63,6 +63,9 @@ def legit_post_from_user1_to_user2(user1, user2)
 end
 
 describe "attack vectors", :type => :request do
+  before do
+    skip # TODO
+  end
 
   let(:eves_aspect) { eve.aspects.find_by_name("generic") }
   let(:alices_aspect) { alice.aspects.find_by_name("generic") }
diff --git a/spec/lib/postzord/receiver/private_spec.rb b/spec/lib/postzord/receiver/private_spec.rb
deleted file mode 100644
index 1dfb94e84..000000000
--- a/spec/lib/postzord/receiver/private_spec.rb
+++ /dev/null
@@ -1,63 +0,0 @@
-#   Copyright (c) 2010-2011, Diaspora Inc.  This file is
-#   licensed under the Affero General Public License version 3 or later.  See
-#   the COPYRIGHT file.
-
-require 'spec_helper'
-
-describe Postzord::Receiver::Private do
-
-  before do
-    @alices_post = alice.build_post(:status_message, :text => "hey", :aspect_ids => [alice.aspects.first.id])
-    @salmon_xml = alice.salmon(@alices_post).xml_for(bob.person)
-  end
-
-  describe '.initialize' do
-    it 'valid for local' do
-      expect(Person).not_to receive(:find_or_fetch_by_identifier)
-      expect(Salmon::EncryptedSlap).not_to receive(:from_xml)
-
-      zord = Postzord::Receiver::Private.new(bob, :person => alice.person, :object => @alices_post)
-      expect(zord.instance_variable_get(:@user)).not_to be_nil
-      expect(zord.instance_variable_get(:@author)).not_to be_nil
-      expect(zord.instance_variable_get(:@object)).not_to be_nil
-    end
-
-    it 'valid for remote' do
-      salmon_double = double()
-      expect(salmon_double).to receive(:author_id).and_return(true)
-      expect(Salmon::EncryptedSlap).to receive(:from_xml).with(@salmon_xml, bob).and_return(salmon_double)
-      expect(Person).to receive(:find_or_fetch_by_identifier).and_return(true)
-
-      zord = Postzord::Receiver::Private.new(bob, :salmon_xml => @salmon_xml)
-      expect(zord.instance_variable_get(:@user)).not_to be_nil
-      expect(zord.instance_variable_get(:@author)).not_to be_nil
-      expect(zord.instance_variable_get(:@salmon_xml)).not_to be_nil
-    end
-  end
-
-  describe '#receive!' do
-    before do
-      @zord = Postzord::Receiver::Private.new(bob, :salmon_xml => @salmon_xml)
-      @salmon = @zord.instance_variable_get(:@salmon)
-    end
-
-    context "does not parse and receive" do
-      it "if the salmon author does not exist" do
-        @zord.instance_variable_set(:@author, nil)
-        expect(@zord).not_to receive(:parse_and_receive)
-        @zord.receive!
-      end
-
-      it "if the author does not match the signature" do
-        @zord.instance_variable_set(:@author, FactoryGirl.create(:person))
-        expect(@zord).not_to receive(:parse_and_receive)
-        @zord.receive!
-      end
-    end
-
-    it 'parses the salmon object' do
-      expect(Diaspora::Parser).to receive(:from_xml).with(@salmon.parsed_data).and_return(@alices_post)
-      @zord.receive!
-    end
-  end
-end
diff --git a/spec/lib/postzord/receiver/public_spec.rb b/spec/lib/postzord/receiver/public_spec.rb
deleted file mode 100644
index a155762a4..000000000
--- a/spec/lib/postzord/receiver/public_spec.rb
+++ /dev/null
@@ -1,107 +0,0 @@
-#   Copyright (c) 2010-2011, Diaspora Inc.  This file is
-#   licensed under the Affero General Public License version 3 or later.  See
-#   the COPYRIGHT file.
-
-require 'spec_helper'
-
-describe Postzord::Receiver::Public do
-  before do
-    @post = FactoryGirl.build(:status_message, :author => alice.person, :public => true)
-    @created_salmon = Salmon::Slap.create_by_user_and_activity(alice, @post.to_diaspora_xml)
-    @xml = @created_salmon.xml_for(nil)
-  end
-
-  describe '#initialize' do
-    it 'creates a Salmon instance variable' do
-      receiver = Postzord::Receiver::Public.new(@xml)
-      expect(receiver.salmon).not_to be_nil
-    end
-  end
-
-  describe '#perform!' do
-    before do
-      @receiver = Postzord::Receiver::Public.new(@xml)
-    end
-
-    it 'calls verify_signature' do
-      expect(@receiver).to receive(:verified_signature?)
-      @receiver.perform!
-    end
-
-    it "does not save the object if signature is not verified" do
-      expect(@receiver).to receive(:verified_signature?).and_return(false)
-      expect(@receiver).not_to receive(:parse_and_receive)
-      @receiver.perform!
-    end
-
-    context 'if signature is valid' do
-      it 'calls recipient_user_ids' do
-        expect(@receiver).to receive(:recipient_user_ids)
-        @receiver.perform!
-      end
-
-      it 'saves the parsed object' do
-        expect(@receiver).to receive(:parse_and_receive).and_call_original
-        @receiver.perform!
-      end
-
-      it 'enqueues a Workers::ReceiveLocalBatch' do
-        expect(Workers::ReceiveLocalBatch).to receive(:perform_async).with(anything, anything, anything)
-        @receiver.perform!
-      end
-
-      it 'intergrates' do
-        inlined_jobs do
-          @receiver.perform!
-        end
-      end
-    end
-  end
-
-  describe '#verify_signature?' do
-    it 'calls Slap#verified_for_key?' do
-      receiver = Postzord::Receiver::Public.new(@xml)
-      expect(receiver.salmon).to receive(:verified_for_key?).with(instance_of(OpenSSL::PKey::RSA))
-      receiver.verified_signature?
-    end
-  end
-
-  describe '#recipient_user_ids' do
-    it 'calls User.all_sharing_with_person' do
-      expect(User).to receive(:all_sharing_with_person).and_return(double(:pluck => []))
-      receiver = Postzord::Receiver::Public.new(@xml)
-      receiver.perform!
-    end
-  end
-
-  describe '#receive_relayable' do
-    before do
-      @comment = bob.build_comment(:text => 'yo', :post => FactoryGirl.create(:status_message))
-      @comment.save
-      created_salmon = Salmon::Slap.create_by_user_and_activity(alice, @comment.to_diaspora_xml)
-      xml = created_salmon.xml_for(nil)
-      @comment.delete
-      @receiver = Postzord::Receiver::Public.new(xml)
-    end
-
-    it 'receives only for the parent author if he is local to the pod' do
-      comment = double.as_null_object
-      @receiver.instance_variable_set(:@object, comment)
-
-      expect(comment).to receive(:receive)
-      @receiver.receive_relayable
-    end
-  end
-
-  describe "#parse_and_receive" do
-    before do
-      @receiver = Postzord::Receiver::Public.new(@xml)
-      @parsed_salmon = Salmon::Slap.from_xml(@xml)
-    end
-
-    it "should raise a Diaspora::XMLNotParseable when the parsed object is nil" do
-      expect(Diaspora::Parser).to receive(:from_xml).and_return(nil)
-      expect { @receiver.parse_and_receive(@parsed_salmon.parsed_data) }.to raise_error(Diaspora::XMLNotParseable)
-    end
-  end
-end
diff --git a/spec/lib/postzord/receiver_spec.rb b/spec/lib/postzord/receiver_spec.rb
index 9dc2ceac7..a86309fb9 100644
--- a/spec/lib/postzord/receiver_spec.rb
+++ b/spec/lib/postzord/receiver_spec.rb
@@ -19,48 +19,4 @@ describe Postzord::Receiver do
       @receiver.perform!
     end
   end
-
-  describe "#author_does_not_match_xml_author?" do
-    before do
-      @receiver.instance_variable_set(:@author, alice.person)
-      allow(@receiver).to receive(:xml_author).and_return(alice.diaspora_handle)
-    end
-
-    it "should return false if the author matches" do
-      allow(@receiver).to receive(:xml_author).and_return(alice.diaspora_handle)
-      expect(@receiver.send(:author_does_not_match_xml_author?)).to be_falsey
-    end
-
-    it "should return true if the author does not match" do
-      allow(@receiver).to receive(:xml_author).and_return(bob.diaspora_handle)
-      expect(@receiver.send(:author_does_not_match_xml_author?)).to be_truthy
-    end
-  end
-
-  describe "#relayable_without_parent?" do
-    before do
-      @receiver.instance_variable_set(:@author, alice.person)
-    end
-
-    it "should return false if object is not relayable" do
-      @receiver.instance_variable_set(:@object, nil)
-      expect(@receiver.send(:relayable_without_parent?)).to be_falsey
-    end
-
-    context "if object is relayable" do
-      before do
-        @comment = bob.build_comment(text: "yo", post: FactoryGirl.create(:status_message))
-        @receiver.instance_variable_set(:@object, @comment)
-      end
-
-      it "should return false if object has parent" do
-        expect(@receiver.send(:relayable_without_parent?)).to be_falsey
-      end
-
-      it "should return true if object has no parent" do
-        @comment.parent = nil
-        expect(@receiver.send(:relayable_without_parent?)).to be_truthy
-      end
-    end
-  end
 end
diff --git a/spec/models/poll_participation_spec.rb b/spec/models/poll_participation_spec.rb
index d56d25e27..67f2c5053 100644
--- a/spec/models/poll_participation_spec.rb
+++ b/spec/models/poll_participation_spec.rb
@@ -77,32 +77,6 @@ describe PollParticipation, :type => :model do
     end
   end
 
-  describe 'federation' do
-    before do
-      #Alice is on pod A and another person is on pod B. Alice posts a poll and participates in the poll.
-      @poll_participant = FactoryGirl.create(:user)
-      @poll_participant_aspect = @poll_participant.aspects.create(:name => "bruisers")
-      connect_users(alice, @alices_aspect, @poll_participant, @poll_participant_aspect)
-      @poll = Poll.new(:question => "hi")
-      @poll.poll_answers.build(:answer => "a")
-      @poll.poll_answers.build(:answer => "b")
-      @post = alice.post :status_message, :text => "hello", :to => @alices_aspect.id
-      @post.poll = @poll
-      @poll_participation_alice = alice.participate_in_poll!(@post, @poll.poll_answers.first)
-    end
-
-    it 'is saved without errors in a simulated A-B node environment' do
-      #stubs needed because the poll participation is already saved in the test db. This is just a simulated federation!
-      allow_any_instance_of(PollParticipation).to receive(:save!).and_return(true)
-      allow_any_instance_of(Person).to receive(:local?).and_return(false)
-      expect{
-        salmon = Salmon::Slap.create_by_user_and_activity(alice, @poll_participation_alice.to_diaspora_xml).xml_for(@poll_participant)
-        parsed_salmon = Salmon::Slap.from_xml(salmon)
-        Postzord::Receiver::Public.new(salmon).parse_and_receive(parsed_salmon.parsed_data)
-      }.to_not raise_error
-    end
-  end
-
   describe 'it is relayable' do
     before do
       @local_luke, @local_leia, @remote_raphael = set_up_friends
diff --git a/spec/workers/receive_spec.rb b/spec/workers/receive_spec.rb
deleted file mode 100644
index 0ee0b0a53..000000000
--- a/spec/workers/receive_spec.rb
+++ /dev/null
@@ -1,23 +0,0 @@
-require 'spec_helper'
-
-describe Workers::Receive do
-  before do
-    @user = alice
-    @person = FactoryGirl.create(:person)
-    @xml = '<xml></xml>'
-    allow(User).to receive(:find){ |id|
-      if id == @user.id
-        @user
-      else
-        nil
-      end
-    }
-  end
-
-  it 'calls receive' do
-    zord_double = double()
-    expect(zord_double).to receive(:parse_and_receive).with(@xml)
-    expect(Postzord::Receiver::Private).to receive(:new).with(@user, anything).and_return(zord_double)
-    Workers::Receive.new.perform(@user.id, @xml, @person.id)
-  end
-end