1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
|
# frozen_string_literal: true
# Copyright (c) 2010-2011, Diaspora Inc. This file is
# licensed under the Affero General Public License version 3 or later. See
# the COPYRIGHT file.
describe PhotosController, :type => :controller do
before do
@alices_photo = alice.post(:photo, :user_file => uploaded_photo, :to => alice.aspects.first.id, :public => false)
@bobs_photo = bob.post(:photo, :user_file => uploaded_photo, :to => bob.aspects.first.id, :public => true)
sign_in alice, scope: :user
request.env["HTTP_REFERER"] = ''
end
describe '#create' do
before do
@params = {
:photo => {:aspect_ids => "all"},
:qqfile => Rack::Test::UploadedFile.new(
Rails.root.join("spec", "fixtures", "button.png").to_s,
"image/png"
)
}
end
it 'accepts a photo from a regular form submission' do
expect {
post :create, params: @params
}.to change(Photo, :count).by(1)
end
it 'returns application/json when possible' do
request.env['HTTP_ACCEPT'] = 'application/json'
expect(post(:create, params: @params).headers["Content-Type"]).to match "application/json.*"
end
it 'returns text/html by default' do
request.env['HTTP_ACCEPT'] = 'text/html,*/*'
expect(post(:create, params: @params).headers["Content-Type"]).to match "text/html.*"
end
end
describe '#create' do
before do
allow(@controller).to receive(:file_handler).and_return(uploaded_photo)
@params = {photo: {user_file: uploaded_photo, aspect_ids: "all", pending: true}}
end
it "creates a photo" do
expect {
post :create, params: @params
}.to change(Photo, :count).by(1)
end
it "doesn't allow mass assignment of person" do
new_user = FactoryBot.create(:user)
@params[:photo][:author] = new_user
post :create, params: @params
expect(Photo.last.author).to eq(alice.person)
end
it "doesn't allow mass assignment of person_id" do
new_user = FactoryBot.create(:user)
@params[:photo][:author_id] = new_user.id
post :create, params: @params
expect(Photo.last.author).to eq(alice.person)
end
it "can set the photo as the profile photo and unpends the photo" do
old_url = alice.person.profile.image_url
@params[:photo][:set_profile_photo] = true
post :create, params: @params
new_url = alice.reload.person.profile.image_url
expect(new_url).not_to eq(old_url)
expect(Photo.find_by(remote_photo_name: new_url.rpartition("_").last).pending).to be_falsey
end
end
describe '#index' do
it "succeeds without any available pictures" do
get :index, params: {person_id: FactoryBot.create(:person).guid}
expect(response).to be_successful
end
it "succeeds on mobile devices without any available pictures" do
get :index, params: {person_id: FactoryBot.create(:person).guid}, format: :mobile
expect(response).to be_successful
end
it "succeeds on mobile devices with available pictures" do
get :index, params: {person_id: bob.person.guid}, format: :mobile
expect(response).to be_successful
end
it "displays the logged in user's pictures" do
get :index, params: {person_id: alice.person.guid}
expect(assigns[:person]).to eq(alice.person)
expect(assigns[:posts]).to eq([@alices_photo])
end
it "displays another person's pictures" do
get :index, params: {person_id: bob.person.guid}
expect(assigns[:person]).to eq(bob.person)
expect(assigns[:posts]).to eq([@bobs_photo])
end
it "displays the correct number of photos" do
16.times do |i|
eve.post(:photo, :user_file => uploaded_photo, :to => eve.aspects.first.id, :public => true)
end
get :index, params: {person_id: eve.person.to_param}
expect(response.body).to include ',"photos_count":16'
eve.post(:photo, :user_file => uploaded_photo, :to => eve.aspects.first.id, :public => false)
get :index, params: {person_id: eve.person.to_param}
expect(response.body).to include ',"photos_count":16' # eve is not sharing with alice
end
it "returns json when requested" do
request.env['HTTP_ACCEPT'] = 'application/json'
get :index, params: {person_id: alice.person.guid}
expect(response.headers['Content-Type']).to match 'application/json.*'
end
it 'displays by date of creation' do
max_time = bob.photos.first.created_at - 1.day
get :index, params: {person_id: bob.person.guid, max_time: max_time.to_i}
expect(assigns[:posts]).to be_empty
end
context "with no user signed in" do
before do
sign_out :user
@person = bob.person
end
it "succeeds" do
get :index, params: {person_id: @person.to_param}
expect(response.status).to eq(200)
end
it "succeeds on the mobile site" do
get :index, params: {person_id: @person.to_param}, format: :mobile
expect(response).to be_successful
end
it "forces to sign in if the person is remote" do
p = FactoryBot.create(:person)
get :index, params: {person_id: p.to_param}
expect(response).to be_redirect
expect(response).to redirect_to new_user_session_path
end
it "displays the correct number of photos" do
16.times do
eve.post(:photo, user_file: uploaded_photo, to: eve.aspects.first.id, public: true)
end
get :index, params: {person_id: eve.person.to_param}
expect(response.body).to include ',"photos_count":16'
eve.post(:photo, user_file: uploaded_photo, to: eve.aspects.first.id, public: false)
get :index, params: {person_id: eve.person.to_param}
expect(response.body).to include ',"photos_count":16'
end
it "displays a person's pictures" do
get :index, params: {person_id: bob.person.guid}
expect(assigns[:person]).to eq(bob.person)
expect(assigns[:posts]).to eq([@bobs_photo])
end
end
end
describe '#destroy' do
it "lets a user delete their message" do
delete :destroy, params: {id: @alices_photo.id}
expect(Photo.find_by_id(@alices_photo.id)).to be_nil
end
it 'will let you delete your profile picture' do
get :make_profile_photo, params: {photo_id: @alices_photo.id}, xhr: true, format: :js
delete :destroy, params: {id: @alices_photo.id}, format: :json
expect(Photo.find_by_id(@alices_photo.id)).to be_nil
end
it 'sends a retraction on delete' do
allow(@controller).to receive(:current_user).and_return(alice)
expect(alice).to receive(:retract).with(@alices_photo)
delete :destroy, params: {id: @alices_photo.id}
end
it 'will not let you destroy posts visible to you' do
delete :destroy, params: {id: @bobs_photo.id}
expect(Photo.find_by_id(@bobs_photo.id)).to be_truthy
end
it 'will not let you destroy posts you do not own' do
eves_photo = eve.post(:photo, :user_file => uploaded_photo, :to => eve.aspects.first.id, :public => true)
delete :destroy, params: {id: eves_photo.id}
expect(Photo.find_by_id(eves_photo.id)).to be_truthy
end
end
describe "#make_profile_photo" do
it 'should return a 201 on a js success' do
get :make_profile_photo, params: {photo_id: @alices_photo.id}, xhr: true, format: :js
expect(response.code).to eq("201")
end
it 'should return a 422 on failure' do
get :make_profile_photo, params: {photo_id: @bobs_photo.id}
expect(response.code).to eq("422")
end
end
describe "#show" do
it 'should return 404 for nonexistent stuff on mobile devices' do
expect {
get :show, params: {person_id: bob.person.guid, id: 772_831}, format: :mobile
}.to raise_error ActiveRecord::RecordNotFound
end
it 'should return 200 for existing stuff on mobile devices' do
get :show, params: {person_id: alice.person.guid, id: @alices_photo.id}, format: :mobile
expect(response).to be_successful
end
it "doesn't leak private photos to the public" do
sign_out :user
expect {
get :show, params: {person_id: alice.person.guid, id: @alices_photo.id}, format: :mobile
}.to raise_error ActiveRecord::RecordNotFound
end
end
end
|
