diff options
| author | Casey Deccio <casey@deccio.net> | 2021-08-17 17:05:29 +0300 |
|---|---|---|
| committer | Casey Deccio <casey@deccio.net> | 2021-08-17 17:05:29 +0300 |
| commit | 039c50906a7aa2e0d0763a9824280ba151947a8d (patch) | |
| tree | d425efdf608e26e85db3ee451e2c2f3c4cf9cb43 | |
| parent | d1a1aced00c315cb24094dd6c5e144e7b0e56d60 (diff) | |
Only graph external signer if there is an analysis
| -rw-r--r-- | dnsviz/viz/dnssec.py | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/dnsviz/viz/dnssec.py b/dnsviz/viz/dnssec.py index 3a0893b..53d37a0 100644 --- a/dnsviz/viz/dnssec.py +++ b/dnsviz/viz/dnssec.py @@ -1296,8 +1296,12 @@ class DNSAuthGraph: for signed_keys, rrset_info in name_obj.get_dnskey_sets(): for rrsig in name_obj.rrsig_status[rrset_info]: signer_obj = name_obj.get_name(rrsig.signer) - if rrsig.signer != name_obj.name and not is_dlv: - self.graph_zone_auth(signer_obj, False) + if signer_obj is not None: + # if we have the analysis corresponding to the signer, then + # graph it too, if it was different from what we were + # expecting + if rrsig.signer != name_obj.name and not is_dlv: + self.graph_zone_auth(signer_obj, False) for dnskey in name_obj.rrsig_status[rrset_info][rrsig]: rrsig_status = name_obj.rrsig_status[rrset_info][rrsig][dnskey] if dnskey is None: |