diff options
author | Casey Deccio <casey@deccio.net> | 2016-07-29 21:07:26 +0300 |
---|---|---|
committer | Casey Deccio <casey@deccio.net> | 2016-07-29 21:07:26 +0300 |
commit | a772d68095a8f870e6806018358e6341b943c76c (patch) | |
tree | 76532e886a0136f1f8177ea59042c9c6e8a95989 | |
parent | 0fc237e60fb63404a9d90c5e3b2325a3fff7010d (diff) |
Consider explicit delegations
-rw-r--r-- | dnsviz/analysis/offline.py | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/dnsviz/analysis/offline.py b/dnsviz/analysis/offline.py index bbaeb81..571e3c1 100644 --- a/dnsviz/analysis/offline.py +++ b/dnsviz/analysis/offline.py @@ -1447,7 +1447,13 @@ class OfflineDomainNameAnalysis(OnlineDomainNameAnalysis): names_from_child = self.get_ns_names_in_child() names_from_parent = self.get_ns_names_in_parent() - auth_ns_response = self.queries[(self.name, dns.rdatatype.NS)].is_valid_complete_authoritative_response_any() + # With explicit delegations we won't have queried for authoritative NS + # records, but we also don't need to check delegation consistency in + # that case. + if (self.name, dns.rdatatype.NS) in self.queries: + auth_ns_response = self.queries[(self.name, dns.rdatatype.NS)].is_valid_complete_authoritative_response_any() + else: + auth_ns_response = False glue_mapping = self.get_glue_ip_mapping() auth_mapping = self.get_auth_ns_ip_mapping() |