Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/dotnet/aspnetcore.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDan Moseley <danmose@microsoft.com>2022-10-12 19:06:04 +0300
committerGitHub <noreply@github.com>2022-10-12 19:06:04 +0300
commit8bf447aa3f9719f6f162598708020dd4b420b49d (patch)
tree939a679fb26580ba7d2631e17785d8c48c3f5c73 /CONTRIBUTING.md
parent678a06f95aced0d4c6f837e53cfc6ffdbb7362b9 (diff)
update contributing guidelines to state that Squash is preferred (#44475)
I understand from @captainsafia that this is de-facto policy. BTW, we may want to require admin elevation for merge and rebase into main. dotnet/runtime does this and it has caused little or no trouble.
Diffstat (limited to 'CONTRIBUTING.md')
-rw-r--r--CONTRIBUTING.md6
1 files changed, 6 insertions, 0 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 71497e9c14..ae65045c86 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -106,6 +106,12 @@ If you don't know what a pull request is read this article: <https://help.github
Your pull request will now go through extensive checks by the subject matter experts on our team. Please be patient; we have hundreds of pull requests across all of our repositories. Update your pull request according to feedback until it is approved by one of the ASP.NET team members. After that, one of our team members may adjust the branch you merge into based on the expected release schedule.
+## Merging pull requests
+
+When your pull request has had all feedback addressed, it has been signed off by one or more reviewers with commit access, and all checks are green, we will commit it.
+
+We commit pull requests as a single Squash commit unless there are special circumstances. This creates a simpler history than a Merge or Rebase commit. "Special circumstances" are rare, and typically mean that there are a series of cleanly separated changes that will be too hard to understand if squashed together, or for some reason we want to preserve the ability to bisect them.
+
## Code of conduct
See [CODE-OF-CONDUCT.md](./CODE-OF-CONDUCT.md)