diff options
| author | Doug Bunting <6431421+dougbu@users.noreply.github.com> | 2020-11-12 21:28:52 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-11-12 21:28:52 +0300 |
| commit | 415875625c1a706322d9a8b5a65aab2129fd80f0 (patch) | |
| tree | 60d9681bebc213582916f31ecc1e18edb1e2577a /Directory.Build.props | |
| parent | 4d47720df24c5fc5a404497e8d3cae9b3673c454 (diff) | |
[release/5.0] Update API baseline files (#27653)
* Move all PublicAPI.Unshipped.txt files to PublicAPI.Shipped.txt
- we have now shipped this API surface
* Add eng/PublicAPI.empty.txt file
- make it easier to add new implementation projects
* Add missing public API baseline files
- #26784 part 1/2
- a few unexpected files turned up missing beyond the #26784 list…
* Reference Microsoft.CodeAnalysis.PublicApiAnalyzers more often
- #27484 part 2/2
- emit errors when API baseline files are missing
- update categorization of some projects
- specification tests are not implementation projects
- but _were_ project reference providers (keep that)
- correct `$(IsTestAssetProject)` setting for Razor shims et cetera
- correct `$(IsSampleProject)` setting for casing of some Sample directories
- Microsoft.AspNetCore.Analyzer.Testing should be treated as test asset
- add `$(AddPublicApiAnalyzers)` property to support overrides
- e.g. for `msbuild` task projects and tools
nit:
- remove useless `$(IsTestProject)` setting in a specification test project
- wrap some long `Condition`s
* Do not run public API analyzer in `RazorCoreCompile` target
* Remove old `$(EnableApiCheck)` settings
- property does nothing
- also remove a dangling ApiCheck comment
Diffstat (limited to 'Directory.Build.props')
| -rw-r--r-- | Directory.Build.props | 19 |
1 files changed, 14 insertions, 5 deletions
diff --git a/Directory.Build.props b/Directory.Build.props index 258a01d388..889ba3aed6 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -11,14 +11,23 @@ <PropertyGroup> <RepoRelativeProjectDir>$([MSBuild]::MakeRelative($(RepoRoot), $(MSBuildProjectDirectory)))</RepoRelativeProjectDir> - <IsBenchmarkProject Condition="$(MSBuildProjectName.EndsWith('.Performance')) OR $(RepoRelativeProjectDir.Contains('perf')) OR $(RepoRelativeProjectDir.Contains('benchmarkapps'))">true</IsBenchmarkProject> + <IsBenchmarkProject Condition=" $(MSBuildProjectName.EndsWith('.Performance')) OR + $(RepoRelativeProjectDir.Contains('perf')) OR + $(RepoRelativeProjectDir.Contains('benchmarkapps')) ">true</IsBenchmarkProject> <IsSpecificationTestProject Condition="$(MSBuildProjectName.EndsWith('.Specification.Tests'))">true</IsSpecificationTestProject> <IsUnitTestProject Condition=" '$(IsUnitTestProject)' == '' ">false</IsUnitTestProject> - <IsUnitTestProject Condition="'$(IsSpecificationTestProject)' != 'true' and ( $(MSBuildProjectName.EndsWith('Tests')) or $(MSBuildProjectName.EndsWith('.Test')) or $(MSBuildProjectName.EndsWith('.FunctionalTest')) )">true</IsUnitTestProject> - <IsTestAssetProject Condition="$(RepoRelativeProjectDir.Contains('testassets'))">true</IsTestAssetProject> - <IsSampleProject Condition="$(RepoRelativeProjectDir.Contains('sample'))">true</IsSampleProject> + <IsUnitTestProject Condition=" '$(IsSpecificationTestProject)' != 'true' AND + ( $(MSBuildProjectName.EndsWith('Tests')) OR + $(MSBuildProjectName.EndsWith('.Test')) OR + $(MSBuildProjectName.EndsWith('.FunctionalTest')) ) ">true</IsUnitTestProject> + <IsTestAssetProject Condition=" $(RepoRelativeProjectDir.Contains('testassets')) ">true</IsTestAssetProject> + <IsSampleProject Condition=" $(RepoRelativeProjectDir.Contains('sample')) OR + $(RepoRelativeProjectDir.Contains('Sample')) ">true</IsSampleProject> <IsAnalyzersProject Condition="$(MSBuildProjectName.EndsWith('.Analyzers'))">true</IsAnalyzersProject> - <IsShipping Condition="'$(IsSampleProject)' == 'true' or '$(IsTestAssetProject)' == 'true' or '$(IsBenchmarkProject)' == 'true' or '$(IsUnitTestProject)' == 'true'">false</IsShipping> + <IsShipping Condition=" '$(IsSampleProject)' == 'true' OR + '$(IsTestAssetProject)' == 'true' OR + '$(IsBenchmarkProject)' == 'true' OR + '$(IsUnitTestProject)' == 'true'">false</IsShipping> <!-- Following logic mimics core-setup approach as well as |