diff options
author | Pranav K <prkrishn@hotmail.com> | 2020-12-07 22:43:55 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-12-07 22:43:55 +0300 |
commit | 8df66d1c1623fd0e4293f2893271c2c769951796 (patch) | |
tree | 468d094f24cde202ba8e4e859c1cea73e30305b9 /Directory.Build.props | |
parent | 3017502573bafe48e07dfc658a9752deb0fc7e29 (diff) |
Add XML doc comments for Microsoft.Net.Http.Headers (#28415)
* Enable missing doc comments to appear as warnings when building locally.
* Update nullability bug that I noticed in RangeConditionHeaderValue
Diffstat (limited to 'Directory.Build.props')
-rw-r--r-- | Directory.Build.props | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/Directory.Build.props b/Directory.Build.props index 7f47ea87b0..449c50e42b 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -100,10 +100,11 @@ <!-- Warnings and errors --> <PropertyGroup> + <!-- Ensure API docs are available. --> + <NoWarn>$(NoWarn.Replace('1591', ''))</NoWarn> + <!-- For local builds, don't make missing XML docs a fatal build error, but still surface so we have visibility into undocumented APIs. --> <WarningsNotAsErrors Condition=" '$(ContinuousIntegrationBuild)' != 'true' ">$(WarningsNotAsErrors);CS1591</WarningsNotAsErrors> - <!-- For CI builds, ensure API docs are available. --> - <NoWarn Condition=" '$(ContinuousIntegrationBuild)' == 'true' ">$(NoWarn.Replace('1591', ''))</NoWarn> <!-- xUnit1004 = warns about skipped tests. Make this a non-fatal build warning. --> <WarningsNotAsErrors>$(WarningsNotAsErrors);xUnit1004</WarningsNotAsErrors> |