Age | Commit message (Collapse) | Author |
|
|
|
|
|
|
|
* Convert all possible DllImports to LibraryImport for .NET 7+
* Explicitly declare entry point on Windows P/Invokes with W suffix.
* Mark as "ref struct".
* Consume latest source generator.
* Permit unsafe blocks.
|
|
|
|
statements (#40886)
Fixes #40877
|
|
* Enable IDE0060
Contributes to https://github.com/dotnet/aspnetcore/issues/24055
|
|
Contributes to https://github.com/dotnet/aspnetcore/issues/24055
Contributes to https://github.com/dotnet/aspnetcore/issues/32087
* This updates most of the repo to use LoggerMessageAttributes. MvcCoreLoggerExtensions is the only standout but it is fairly involved since it mixes logging from several types, re-uses logger ids etc
|
|
- alternate to #40173
|
|
|
|
|
|
1. Enables CA2249
2. formatted `.editorconfig`
|
|
CA 1847 - https://docs.microsoft.com/en-gb/dotnet/fundamentals/code-analysis/quality-rules/ca1847
Contributes to #24055
|
|
Contributes to https://github.com/dotnet/aspnetcore/issues/24055
|
|
Contributes to #24055
|
|
Contributes to https://github.com/dotnet/aspnetcore/issues/24055
Fixes https://github.com/dotnet/aspnetcore/issues/39555
|
|
|
|
Contributes to https://github.com/dotnet/aspnetcore/issues/24055
|
|
Contributes to https://github.com/dotnet/aspnetcore/issues/24055
|
|
Contributes to https://github.com/dotnet/aspnetcore/issues/24055
|
|
Contributes to #24055
|
|
Contributes to https://github.com/dotnet/aspnetcore/issues/24055 (#39320)
|
|
* Enforce warnings for unused usings
Contributes to https://github.com/dotnet/aspnetcore/issues/24055
|
|
|
|
* Fixup whitespace issues from top-level statement change
The top-level statement codefix resulted in the formatting within
nested lambdas to be incorrect in a number of places. As a part of this change,
I enabled the styling diagnostic and re-ran the tool to correct these issues.
|
|
* Sync shared code from runtime
* Also exclude tests from file-scoped rules
Co-authored-by: Tratcher <Tratcher@users.noreply.github.com>
Co-authored-by: Pranav K <prkrishn@hotmail.com>
|
|
* Use file scoped namespaces
|
|
* Re-enable CA1305
Fixes https://github.com/dotnet/aspnetcore/issues/34361
|
|
Fixes #18873.
|
|
* Update templates to use file-scoped namespace declarations
* Move to SDK version that supports file-scoped namespaces
* Make CA1305 a suggestion rather than error
- New compiler now makes this appear when using a StringBuilder with string interpolation. Logged #34361 to follow up.
Contributes to #33947
|
|
* Enable build time warnings for IDE code analysis rules
* Enables build time warnings for readonly, modifier ordering and const
* Fixes all of the warnings
Contributes to https://github.com/dotnet/aspnetcore/issues/24055
|
|
|
|
A lot of the warnings for this rule appear from logging. Given this is going
to be replaced by a source generator, this change soft enables the rule while
fixing warnings that appear in non-logging code
Contributes to #24055
|
|
Adds CA1842, CA1843, CA2008-CA2011, CA2013, CA2014, CA2016, CA2200, CA2208
|
|
* Move CA1845 analyzer back to warning level
* Fix warnings in src/ProjectTemplates/Shared/AspNetProcess.cs
|
|
* Update SDK
* Add diagnostic for tracing in test
* Try disable publish trimming
* Revert "Try disable publish trimming"
This reverts commit 766ae32611a13e9f6df6279b2e0cb8aaf36d77eb.
* Add BuiltInComInteropSupport
* Update global.json
* Update global.json
* Fix analyzer warning and clean up workarounds
* Fix up more analyzer warnings
* Fix CA1846 issues in WebEncoders and Http
* Fix CA1845 warnings in Logging.AzureAppServices
* Fix CA1845 warning in RazorPagesRazorViewEngineOptionsSetup
* Fix warning in FileProviderRazorProjectFileSystem
* Disable span warnings in tests
* Re-ordering
* Downgrade CA1846 to suggestion for projects
Co-authored-by: John Luo <johluo@microsoft.com>
Co-authored-by: Tanay Parikh <TanayParikh@users.noreply.github.com>
Co-authored-by: Safia Abdalla <safia@safia.rocks>
Co-authored-by: Safia Abdalla <safia@microsoft.com>
Co-authored-by: Pranav K <prkrishn@hotmail.com>
|
|
* Enable CA1835-CA1841, CA1845, CA1846
|
|
* Enable CA1821, CA1825-CA1834
Contributes to https://github.com/dotnet/aspnetcore/issues/24055
|
|
* Enable CA1805 diagnostics
|
|
* Turn on some CodeAnalysis rules
|
|
|
|
* Use analyzers from .NET SDK
|
|
* Enable string comparison FxCop rules
Co-authored-by: Kevin Pilch <me@pilchie.com>
|
|
All rules are currently disabled, except for one that I enabled for
src/Http via a new ".editorconfig" file I added there.
Other changes:
* Allow editorconfigs in MVC and Razor to flow to the root
* Consolidate a few editorconfig settings
* Tweak Ruleset config in Azure/AzureAD where it clashed.
Addresses the beginning of #9620, but it's a fair chunk of work to
enable most rules through the whole repo. That can be done directory by
directory and rule by rule by dropping .editorconfig files though.
|
|
* Added UTF8 BOMs to .razor and .cshtml files
* Fixes and unquarantined BOM tests
* Update .editorconfig
|
|
plumbing (#7934)
* Removes a bunch of trivial usage of Blazor
... in names and comments where we don't specifically mean Blazor.
* Remove obsolete Startup from Components app
* Move UseBlazor into Blazor.Server
Moves UseBlazor and the related features in Blazor.Server - along with
some other general cleanup of misc shared files.
Now Components.Server has a much slimmer set of dependencies (MVC is
gone) and doesn't contain the "double startup" pattern that we
introduced (sorry).
We'll revisit UseBlazor and the dependencies there once the new
MapFallbackToFile support is available from static files.
* minor PR feedback
* Update reference assemblies
* fix broken test
|
|
This refactors the targets used to build the shared framework and its .zip files. There are lots of reasons motivating this: Arcade convergence, migration to VSTS, making it easier to build this locally, etc.
Changes:
* Moves move content of build/Sharedfx.{props/targets} into eng/targets/SharedFx.Common.{props/targets}
* Update the build to produce a `runtime.$rid.Microsoft.AspNetCore.App` package (not just the one with symbols in it)
* Refactor the targets which produce .tar.gz/.zip files into separate projects in `src/Installers/`
* Refactor installers, unit tests, and the framework projects to use ProjectReference to flow dependencies between different parts of the build.
* Makes it easier to build the shared framework locally (for the inner dev loop, you can run `dotnet build -p src/Framework/Microsoft.AspNetCore.App/src/ -r win-x64`)
|
|
(#566)
Moves build logic from other infrastructure repos into aspnet/Universe.
|