diff options
| author | David Wrighton <davidwr@microsoft.com> | 2022-11-11 03:50:03 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-11-11 03:50:03 +0300 |
| commit | 7db5a577938d83c76f0654635d6ffe1598358097 (patch) | |
| tree | 6d8e1db46c37da687bbd275c105cb350e5ea45c3 | |
| parent | 78322ae89f4e2be735520bcb34f8a6eb8a769295 (diff) | |
Fix morph issue with fgOptimizeEqualityComparisonWithConst (#78187)
* Fix morph issue with fgOptimizeEqualityComparisonWithConst
- On arm32 a shift of a long requires a helper call, but the optimization in fgOptimizeEqualityComparisonWithConst for converting a right shift into a left shift was not keeping the GTF_CALL flag on the GenTree node.
* Update src/coreclr/jit/morph.cpp
Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
| -rw-r--r-- | src/coreclr/jit/morph.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/coreclr/jit/morph.cpp b/src/coreclr/jit/morph.cpp index ea291fd21c3..2842b3b3e7d 100644 --- a/src/coreclr/jit/morph.cpp +++ b/src/coreclr/jit/morph.cpp @@ -11476,8 +11476,8 @@ GenTree* Compiler::fgOptimizeEqualityComparisonWithConst(GenTreeOp* cmp) rshiftOp->gtOp1 = andOp->gtGetOp2(); andOp->gtOp2 = rshiftOp; - rshiftOp->SetAllEffectsFlags(rshiftOp->gtGetOp1(), rshiftOp->gtGetOp2()); rshiftOp->SetOper(GT_LSH); + gtUpdateNodeSideEffects(rshiftOp); } // Reverse the condition if necessary. |