diff options
| author | Viktor Hofer <viktor.hofer@microsoft.com> | 2021-02-23 03:37:40 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-02-23 03:37:40 +0300 |
| commit | 503a772595a5b988d086bff901055facf46c46ae (patch) | |
| tree | 63400627ecdfff25a248617ff5a5616068797ebe /Directory.Build.props | |
| parent | 94e62c916855a16cf1357cc41449b0bca6326db7 (diff) | |
Set nuspec packaging properties correctly (#48625)
Define PackageProjectUrl which is the public facing property to specify
a project url in a nuspec. Arcade defaults PackageProjectUrl to
RepositoryUrl if it isn't set. RepositoryUrl was incorrectly set to
git://github.com/dotnet/runtime instead of
https://github.com/dotnet/runtime which cause PackageProjectUrl to use
that incorrect value as well which ultimately results in nuget.org
failing package validation and refusing to add the package.
Also changing ProjectUrl to the previous https://dot.net value which is
the expected url to the dotnet project. In addition to that, specifying
Owners which aren't set anymore in 6.0.
Adding the ProjectUrl property as well as the
Microsoft.DotNet.Build.Tasks.Packaging package depends on it. That line
can be removed after the fix to not override its value unconditionally
is merged and consumed.
Diffstat (limited to 'Directory.Build.props')
| -rw-r--r-- | Directory.Build.props | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/Directory.Build.props b/Directory.Build.props index 552f488feb4..59ea4f1edc0 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -217,9 +217,11 @@ <!-- Packaging --> <PropertyGroup> <GitHubRepositoryName>runtime</GitHubRepositoryName> - <RepositoryUrl>git://github.com/dotnet/$(GitHubRepositoryName)</RepositoryUrl> - <ProjectUrl>https://github.com/dotnet/$(GitHubRepositoryName)</ProjectUrl> - <LicenseUrl>https://github.com/dotnet/$(GitHubRepositoryName)/blob/master/LICENSE.TXT</LicenseUrl> + <RepositoryUrl>https://github.com/dotnet/$(GitHubRepositoryName)</RepositoryUrl> + <PackageProjectUrl>https://dot.net</PackageProjectUrl> + <!-- Remove ProjectUrl after https://github.com/dotnet/arcade/pull/6995 is merged and consumed. --> + <ProjectUrl>$(PackageProjectUrl)</ProjectUrl> + <Owners>microsoft,dotnetframework</Owners> <RuntimeIdGraphDefinitionFile>$([MSBuild]::NormalizePath('$(LibrariesProjectRoot)', 'Microsoft.NETCore.Platforms', 'pkg', 'runtime.json'))</RuntimeIdGraphDefinitionFile> <LicenseFile>$(MSBuildThisFileDirectory)LICENSE.TXT</LicenseFile> <PackageLicenseExpression>MIT</PackageLicenseExpression> |