diff options
author | Viktor Hofer <viktor.hofer@microsoft.com> | 2021-05-19 21:04:01 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-05-19 21:04:01 +0300 |
commit | 68c5658b9308dc4044b971f95b7e3fa4cee374f6 (patch) | |
tree | 091dd10a18352084d0879ea474c06ad02d0a9a9e /Directory.Build.props | |
parent | 220fee407b163a143e8568e3c0b85133ab12958a (diff) |
Stop reading TargetFramework prop in props files (#52897)
* Stop reading TargetFramework prop in props files
The TargetFramework property isn't expected to be set in props files
before a project's body is evaluated.
Don't let BuildTargetFramework property fallback to TargetFramework as
BTF's sole intent is to convey the TargetFramework to filter to and not
the current selected TargetFramework. Reduce usage of BTF so that it is
only used in places where code is actually conditioned on filtering.
In addition to that, specify BuildTargetFramework as a global property for
all traversal builds so when invoking one of the traversal projects directly
(src.proj, ref.proj, etc.), BuildTargetFramework doesn't need to specified
manually to get the default behavior (filter on compatible to net6.0).
Remove the inferred BuildingNetCoreAppVertical because of that and
inline its meaning.
Make sendtohelix a normal NoTargets proj so that it has access to the
properties which were moved into the Directory.Build.targets file as
otherwise it wouldn't import that file.
Diffstat (limited to 'Directory.Build.props')
-rw-r--r-- | Directory.Build.props | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/Directory.Build.props b/Directory.Build.props index 77b581d1986..1b44d591a9a 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -258,7 +258,6 @@ '$(MSBuildProjectExtension)' != '.sfxproj')">false</GeneratePackage> </PropertyGroup> - <!-- Language configuration --> <PropertyGroup> <!-- default to allowing all language features --> @@ -277,4 +276,8 @@ <!-- By default the SDK produces ref assembly for 5.0 or later --> <ProduceReferenceAssembly>false</ProduceReferenceAssembly> </PropertyGroup> + + <PropertyGroup> + <CustomAfterTraversalProps>$(RepositoryEngineeringDir)TraversalSdk.AfterProps.props</CustomAfterTraversalProps> + </PropertyGroup> </Project> |