diff options
| author | Stephen Toub <stoub@microsoft.com> | 2020-09-18 00:40:01 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-09-18 00:40:01 +0300 |
| commit | e0e1919aef7176fb7cabd8a85cad26d80e62728f (patch) | |
| tree | 476f6fe68de51641507b23e1fed4471cf9898d8d /Directory.Build.props | |
| parent | 876980c5ed9d97913f121fbd465316217fef6d9b (diff) | |
Fix handling of repo analyzers and warnings-as-errors (#42272)
* Fix handling of repo analyzers and warnings-as-errors
When we brought in the new SDK, it enabled analyzers by default (which then used our custom ruleset), but a bunch of projects (in particular tests) weren't expecting that, such that we now have thousands of warnings in the repo. This opts-out those projects.
It also enables warnings-as-errors at the root level of the repo, to hopefully avoid such warning storms in the future, and to also clean up the remaining that exist. This includes a bunch of new obsoletion and platform compat warnings that are firing in the runtime tests.
We may choose to run analyzers on additional projects in the future where it's currently disabled, but this gets us back to a state at least as good if not better than we were previously.
* Fix analyzer warnings on Microsoft.NET.HostModel
Fixes the warnings that were triggered by our rule set applying to this project. All fixes were automated.
* Fix analyzer warnings in additional projects
* Remove several `<RunAnalyzers>false</RunAnalyzers>`
* Try to opt-out remaining coreclr tests
Co-authored-by: David Mason <davmason@microsoft.com>
Diffstat (limited to 'Directory.Build.props')
| -rw-r--r-- | Directory.Build.props | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/Directory.Build.props b/Directory.Build.props index e4d1872cb98..d49aa20c15a 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -101,6 +101,7 @@ <LangVersion>preview</LangVersion> <LangVersion Condition="'$(MSBuildProjectExtension)' == '.vbproj'">latest</LangVersion> <Deterministic>true</Deterministic> + <TreatWarningsAsErrors>true</TreatWarningsAsErrors> </PropertyGroup> <PropertyGroup> |