Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/dotnet/runtime.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKunal Pathak <Kunal.Pathak@microsoft.com>2021-03-10 20:48:41 +0300
committerGitHub <noreply@github.com>2021-03-10 20:48:41 +0300
commit9d94811aa71d22bf5ec2fe1c6264dfd56909a689 (patch)
treeb63a05c1ff2bd7f606ba7f3daa7973b50553e040 /src/coreclr/ToolBox
parent36daea12de13affe1cf78b9f619eec2aab50d334 (diff)
Superpmi collection pipeline improvements (#49385)
* Do not pass --use-zapdisable to dotnet But instead pass to individual CoreRun.exe that is launched during benchmark run. That way we do not slow down the launch of dotnet.exe process. * Fail superpmi collection pipeline if there was no valid .mch files were found to merge * Upload merged .mch files as zipped artifacts TODO: Upload the superpmi.log from all the partition runs * TEMP: New Jit guid - Add new JIT guid so we don't overwrite the existing .mch files - Disable all the runs except benchmarks * add trailing path sep * Upload superpmi.logs separately * Use PublishPipelineArtifacts instead of upload artifacts * properly pass zapdisable to CoreRun.exe * Revert "TEMP: New Jit guid" This reverts commit e89ef69625e4e57bb622fc35ff66d82f14b34285. * Remove CoreClrTestBuildHost from benchmark run * fix --envVars for benchmarks run * add missing space * temporary disable other runs * Revert "temporary disable other runs" This reverts commit 2926d1f582061eee6c7852046982ffb5107887b3.
Diffstat (limited to 'src/coreclr/ToolBox')
-rw-r--r--src/coreclr/ToolBox/superpmi/mcs/verbmerge.cpp6
1 files changed, 6 insertions, 0 deletions
diff --git a/src/coreclr/ToolBox/superpmi/mcs/verbmerge.cpp b/src/coreclr/ToolBox/superpmi/mcs/verbmerge.cpp
index efd6a53a87a..c141c1864b0 100644
--- a/src/coreclr/ToolBox/superpmi/mcs/verbmerge.cpp
+++ b/src/coreclr/ToolBox/superpmi/mcs/verbmerge.cpp
@@ -575,6 +575,12 @@ CLEAN_UP:
LogError("Failed to delete file after MCS /merge failed. GetLastError()=%u", GetLastError());
}
}
+ else
+ {
+ // if no files found to merge, then there was some problem.
+ LogError("No files found to merge.");
+ result = (totalSize == 0) ? 1 : 0;
+ }
delete[] nameOfOutputFileAsWchar;
return result;