diff options
| author | Bruce Forstall <brucefo@microsoft.com> | 2021-03-24 00:01:40 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-03-24 00:01:40 +0300 |
| commit | cb8889486f2b55b7e0d5cfeb56198fa2b56518ae (patch) | |
| tree | 522b7bb851416012c4e2db4053c9d5e6d6a5325c /src/coreclr/jit/fgdiagnostic.cpp | |
| parent | 3c1f142c1d717f86b2f64b4d2843ab0dd689a13e (diff) | |
Comments and cleanup for loop cloning (#49768)
* Comments and cleanup for loop cloning
This is a no-diff change
Added various comments to document loop cloning.
Standardized and improved some logging.
Consolidated more loop cloning condition checking into
`optIsLoopClonable` that was previously in `optIdentifyLoopOptInfo`.
Replaced some `0` weights with `BB_ZERO_WEIGHT`.
Made FMT_BB use pervasive.
* Review feedback
Added FMT_LP formatting string.
Cached often-used `optLoopTable[loopInd]` expression.
Added `const` to many loop query member functions.
Added static `GenTree::OperIs(compareOper, oper, oper, oper...)`
functions for simplifying oper check expressions where the
compareOper isn't from a GenTree node `OperGet()`. (This doesn't
need to be part of GenTree, but it doesn't hurt, either.)
Added a few more comments.
* Fix static OperIs
Rename to StaticOperIs. It appears the compiler uses the wrong
template in some cases, but doesn't complain about duplicate
options, leading to run-time failures.
Diffstat (limited to 'src/coreclr/jit/fgdiagnostic.cpp')
| -rw-r--r-- | src/coreclr/jit/fgdiagnostic.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/coreclr/jit/fgdiagnostic.cpp b/src/coreclr/jit/fgdiagnostic.cpp index 8f3a80c6dd0..52eed92f2ea 100644 --- a/src/coreclr/jit/fgdiagnostic.cpp +++ b/src/coreclr/jit/fgdiagnostic.cpp @@ -764,7 +764,7 @@ bool Compiler::fgDumpFlowGraph(Phases phase) { if (createDotFile) { - fprintf(fgxFile, " BB%02u [label = \"BB%02u\\n\\n", block->bbNum, block->bbNum); + fprintf(fgxFile, " " FMT_BB " [label = \"" FMT_BB "\\n\\n", block->bbNum, block->bbNum); // "Raw" Profile weight if (block->hasProfileWeight()) |