Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/dotnet/runtime.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJakob Botsch Nielsen <Jakob.botsch.nielsen@gmail.com>2022-04-22 22:48:07 +0300
committerGitHub <noreply@github.com>2022-04-22 22:48:07 +0300
commit58596ad8eced7ea2d3d29599890ebc40fa175f17 (patch)
tree4318e8e8503018cd2e78605464de93fae1ab349c /src/coreclr/scripts
parent427b76374940eca3699b84bce3d94293c154e64a (diff)
Rename superpmi-asmdiffs -> superpmi-diffs (#68378)
In anticipation of using this pipeline more generally from base-diff JIT comparisons in JIT PRs.
Diffstat (limited to 'src/coreclr/scripts')
-rw-r--r--src/coreclr/scripts/superpmi-diffs.proj (renamed from src/coreclr/scripts/superpmi-asmdiffs.proj)4
-rw-r--r--src/coreclr/scripts/superpmi_diffs.py (renamed from src/coreclr/scripts/superpmi_asmdiffs.py)8
-rw-r--r--src/coreclr/scripts/superpmi_diffs_setup.py (renamed from src/coreclr/scripts/superpmi_asmdiffs_setup.py)17
-rw-r--r--src/coreclr/scripts/superpmi_diffs_summarize.py (renamed from src/coreclr/scripts/superpmi_asmdiffs_summarize.py)6
4 files changed, 18 insertions, 17 deletions
diff --git a/src/coreclr/scripts/superpmi-asmdiffs.proj b/src/coreclr/scripts/superpmi-diffs.proj
index 661a60aca83..39f55de4740 100644
--- a/src/coreclr/scripts/superpmi-asmdiffs.proj
+++ b/src/coreclr/scripts/superpmi-diffs.proj
@@ -6,7 +6,7 @@
<Project DefaultTargets="printItems">
Once you've done that you can run this to see the results:
- dotnet msbuild .\superpmi-asmdiffs.proj /v:n
+ dotnet msbuild .\superpmi-diffs.proj /v:n
-->
<!-- <PropertyGroup>
@@ -30,7 +30,7 @@
<SuperpmiLogsLocation>%HELIX_WORKITEM_UPLOAD_ROOT%</SuperpmiLogsLocation>
<!-- Workaround until https://github.com/dotnet/arcade/pull/6179 is not available -->
<HelixResultsDestinationDir>$(BUILD_SOURCESDIRECTORY)\artifacts\helixresults</HelixResultsDestinationDir>
- <WorkItemCommand>$(Python) $(ProductDirectory)\superpmi_asmdiffs.py -base_jit_directory $(ProductDirectory)\base -diff_jit_directory $(ProductDirectory)\diff -log_directory $(SuperpmiLogsLocation)</WorkItemCommand>
+ <WorkItemCommand>$(Python) $(ProductDirectory)\superpmi_diffs.py -base_jit_directory $(ProductDirectory)\base -diff_jit_directory $(ProductDirectory)\diff -log_directory $(SuperpmiLogsLocation)</WorkItemCommand>
<WorkItemTimeout>1:00</WorkItemTimeout>
</PropertyGroup>
diff --git a/src/coreclr/scripts/superpmi_asmdiffs.py b/src/coreclr/scripts/superpmi_diffs.py
index cf38921f6b9..7fcc1f69dab 100644
--- a/src/coreclr/scripts/superpmi_asmdiffs.py
+++ b/src/coreclr/scripts/superpmi_diffs.py
@@ -3,11 +3,11 @@
# Licensed to the .NET Foundation under one or more agreements.
# The .NET Foundation licenses this file to you under the MIT license.
#
-# Title : superpmi_asmdiffs.py
+# Title : superpmi_diffs.py
#
# Notes:
#
-# Script to run "superpmi asmdiffs" for various collections on the Helix machines.
+# Script to do base-diff jit measurements for various collections on the Helix machines.
#
################################################################################
################################################################################
@@ -126,9 +126,9 @@ def copy_dasm_files(spmi_location, upload_directory, tag_name):
def main(main_args):
- """ Run superpmi asmdiffs process on the Helix machines.
+ """ Run base-diff JIT measurements on the Helix machines.
- See superpmi_asmdiffs_setup.py for how the directory structure is set up in the
+ See superpmi_diffs_setup.py for how the directory structure is set up in the
correlation payload. This script lives in the root of that directory tree.
Args:
diff --git a/src/coreclr/scripts/superpmi_asmdiffs_setup.py b/src/coreclr/scripts/superpmi_diffs_setup.py
index 0342db7b56a..3b59d6e4ef8 100644
--- a/src/coreclr/scripts/superpmi_asmdiffs_setup.py
+++ b/src/coreclr/scripts/superpmi_diffs_setup.py
@@ -3,16 +3,17 @@
# Licensed to the .NET Foundation under one or more agreements.
# The .NET Foundation licenses this file to you under the MIT license.
#
-# Title : superpmi_asmdiffs_setup.py
+# Title : superpmi_diffs_setup.py
#
# Notes:
#
-# Script to setup the directory structure required to perform SuperPMI asmdiffs in CI.
-# It creates `correlation_payload_directory` with `base` and `diff` directories
-# that contain clrjit*.dll. It figures out the baseline commit hash to use for
-# a particular GitHub pull request, and downloads the JIT rolling build for that
-# commit hash. It downloads the jitutils repo and builds the jit-analyze tool. It
-# downloads a version of `git` to be used by jit-analyze.
+# Script to setup the directory structure required to perform base-diff JIT
+# measurements in CI. It creates `correlation_payload_directory` with `base`
+# and `diff` directories # that contain clrjit*.dll. It figures out the baseline
+# commit hash to use for a particular GitHub pull request, and downloads the
+# JIT rolling build for that commit hash. It downloads the jitutils repo and
+# builds the jit-analyze tool. It downloads a version of `git` to be used by
+# jit-analyze.
#
################################################################################
################################################################################
@@ -91,7 +92,7 @@ def match_superpmi_tool_files(full_path):
def main(main_args):
- """ Prepare the Helix data for SuperPMI asmdiffs Azure DevOps pipeline.
+ """ Prepare the Helix data for SuperPMI diffs Azure DevOps pipeline.
The Helix correlation payload directory is created and populated as follows:
diff --git a/src/coreclr/scripts/superpmi_asmdiffs_summarize.py b/src/coreclr/scripts/superpmi_diffs_summarize.py
index 9601d91e56b..01252a70a30 100644
--- a/src/coreclr/scripts/superpmi_asmdiffs_summarize.py
+++ b/src/coreclr/scripts/superpmi_diffs_summarize.py
@@ -4,7 +4,7 @@
## The .NET Foundation licenses this file to you under the MIT license.
#
##
-# Title: superpmi_asmdiffs_summarize.py
+# Title: superpmi_diffs_summarize.py
#
# Notes:
#
@@ -78,8 +78,8 @@ def append_diff_file(f, arch, file_name, full_file_path):
with open(full_file_path, "r") as current_superpmi_md:
contents = current_superpmi_md.read()
- # Were there actually any diffs? We currently look to see if the file contains the text "No diffs found",
- # inserted by `superpmi_asmdiffs.py`, instead of just not having a diff summary .md file.
+ # Were there actually any asm diffs? We currently look to see if the file contains the text "No diffs found",
+ # inserted by `superpmi_diffs.py`, instead of just not having a diff summary .md file.
# (A missing file has the same effect.)
match_obj = re.search(r'^No diffs found', contents)
if match_obj is not None: