Added null check for writers to include in vss (issue 3494).

Improved exception logging.

1 files changed, 11 insertions, 8 deletions

diff --git a/Duplicati/Library/Common/IO/VssBackupComponents.cs b/Duplicati/Library/Common/IO/VssBackupComponents.cs
index e236aff8c..bffaa28d6 100644
--- a/Duplicati/Library/Common/IO/VssBackupComponents.cs
+++ b/Duplicati/Library/Common/IO/VssBackupComponents.cs
@@ -73,7 +73,7 @@ namespace Duplicati.Library.Common.IO
                 _vssBackupComponents.EnableWriterClasses(includedWriters);

 

             if (excludedWriters != null && excludedWriters.Length > 0)

-                _vssBackupComponents.DisableWriterClasses(excludedWriters.ToArray());

+                _vssBackupComponents.DisableWriterClasses(excludedWriters);

 

             try

             {

@@ -84,6 +84,11 @@ namespace Duplicati.Library.Common.IO
                 _vssBackupComponents.FreeWriterMetadata();

             }

 

+            if (includedWriters == null)
+            {

+                return;

+            }

+

             // check if writers got enabled

             foreach (var writerGUID in includedWriters)
             {

@@ -128,7 +133,6 @@ namespace Duplicati.Library.Common.IO
             get {

                 return _volumeReverseMap;

             }

-

         }

 

         private List<string> GetPathsFromComponent(IVssWMComponent component)
@@ -197,7 +201,6 @@ namespace Duplicati.Library.Common.IO
             return volumePath;

         }

 

-

         public void CheckSupportedVolumes(IEnumerable<string> sources)

         {

             //Figure out which volumes are in the set

@@ -281,12 +284,12 @@ namespace Duplicati.Library.Common.IO
         public static IVssBackupComponents GetVssBackupComponents()
         {

             //Prepare the backup

-            IVssBackupComponents m_backup = CreateVssBackupComponents();

-            m_backup.InitializeForBackup(null);

-            m_backup.SetContext(VssSnapshotContext.Backup);

-            m_backup.SetBackupState(false, true, VssBackupType.Full, false);

+            IVssBackupComponents vssBackupComponents = CreateVssBackupComponents();

+            vssBackupComponents.InitializeForBackup(null);

+            vssBackupComponents.SetContext(VssSnapshotContext.Backup);

+            vssBackupComponents.SetBackupState(false, true, VssBackupType.Full, false);

 

-            return m_backup;

+            return vssBackupComponents;

         }

 

         public static IVssBackupComponents CreateVssBackupComponents()