diff options
| author | Jan Kundrát <jan.kundrat@cesnet.cz> | 2019-06-10 11:54:49 +0300 |
|---|---|---|
| committer | Jan Kundrát <jan.kundrat@cesnet.cz> | 2019-06-10 11:54:49 +0300 |
| commit | c60f790793d42398f94634d0f1a11ddef7609b05 (patch) | |
| tree | 8dc033a7a32e133057362ddd2d0d258e87409648 /CMakeLists.txt | |
| parent | e0b4ec54bd044e414081d0554b71994b6ce74e25 (diff) | |
Do not impose -Wextra -Wconversion etc on library users
I had to nuke the flags targetting spdlog_header_only because in CMake,
an interface target apparently really only supports the INTERFACE
option.
As I am only targeting Linux, the MSVC changes rely on spdlog's CI and
manual code review. That said, it makes sense to also stop forcing these
options on third party code, assuming that the CMake installations work
the same on Windows.
Fixes #1104
Diffstat (limited to 'CMakeLists.txt')
| -rw-r--r-- | CMakeLists.txt | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/CMakeLists.txt b/CMakeLists.txt index f99bfc83..dcc54309 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -80,12 +80,10 @@ target_link_libraries(spdlog_header_only INTERFACE Threads::Threads) #--------------------------------------------------------------------------------------- if(SPDLOG_MASTER_PROJECT) if (CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang|AppleClang") - target_compile_options( spdlog PUBLIC -Wall -Wextra -Wconversion -pedantic -Wfatal-errors) - target_compile_options( spdlog_header_only INTERFACE -Wall -Wextra -Wconversion -pedantic -Wfatal-errors) + target_compile_options( spdlog PRIVATE -Wall -Wextra -Wconversion -pedantic -Wfatal-errors) endif() if (CMAKE_CXX_COMPILER_ID MATCHES "MSVC") - target_compile_options( spdlog PUBLIC /W3 /WX ) - target_compile_options( spdlog_header_only INTERFACE /W3 /WX) + target_compile_options( spdlog PRIVATE /W3 /WX ) endif() include(cmake/sanitizers.cmake) @@ -162,4 +160,4 @@ if (SPDLOG_INSTALL) #--------------------------------------------------------------------------------------- include(cmake/spdlogCPack.cmake) -endif ()
\ No newline at end of file +endif () |