tests: mark unused assignments with underscore

These are all test scripts that store the results of setup in variables.
Even though they're not used, having them helps make clear what data the
test has available to it, and follows existing patterns.

5 files changed, 10 insertions, 10 deletions

diff --git a/spec/models/book_spec.rb b/spec/models/book_spec.rb
index ec915cec..9019b4da 100644
--- a/spec/models/book_spec.rb
+++ b/spec/models/book_spec.rb
@@ -14,7 +14,7 @@ RSpec.describe Book, type: :model do
   end
 
   it "should have 4 chapters" do
-    chapter = Fabricate(:chapter, book: book)
+    _chapter = Fabricate(:chapter, book: book)
     expect(book.chapters.count).to eql(4)
   end
 end
diff --git a/spec/models/doc_version_spec.rb b/spec/models/doc_version_spec.rb
index 5d470b57..f9ba2d48 100644
--- a/spec/models/doc_version_spec.rb
+++ b/spec/models/doc_version_spec.rb
@@ -12,7 +12,7 @@ RSpec.describe DocVersion, type: :model do
     file = Fabricate(:doc_file, name: "test-command")
     docs = range.map { |i| Fabricate(:doc, plain: "Doc #{i}") }
     vers = range.map { |i| Fabricate(:version, name: "#{i}.0", vorder: Version.version_to_num("#{i}.0")) }
-    dver = range.map { |i| Fabricate(:doc_version, doc_file: file, version: vers[i], doc: docs[i]) }
+    _dver = range.map { |i| Fabricate(:doc_version, doc_file: file, version: vers[i], doc: docs[i]) }
 
     dv = DocVersion.latest_version
     expect(docs[3]).to eql(dv.doc)
@@ -23,7 +23,7 @@ RSpec.describe DocVersion, type: :model do
     file = Fabricate(:doc_file, name: "test-command")
     docs = range.map { |i| Fabricate(:doc, plain: "Doc #{i}") }
     vers = range.map { |i| Fabricate(:version, name: "v#{i}.0") }
-    dver = range.map { |i| Fabricate(:doc_version, doc_file: file, version: vers[i], doc: docs[i]) }
+    _dver = range.map { |i| Fabricate(:doc_version, doc_file: file, version: vers[i], doc: docs[i]) }
 
     dv = DocVersion.for_version("v2.0")
     expect(docs[2]).to eql(dv.doc)
diff --git a/test/functional/books_controller_test.rb b/test/functional/books_controller_test.rb
index 994258b7..e0a9399d 100644
--- a/test/functional/books_controller_test.rb
+++ b/test/functional/books_controller_test.rb
@@ -9,7 +9,7 @@ class BooksControllerTest < ActionController::TestCase
   end
 
   test "gets the book page" do
-    book = FactoryBot.create(:book, code: "en")
+    _book = FactoryBot.create(:book, code: "en")
     get :show, params: { lang: "en" }
     assert_response :success
   end
diff --git a/test/functional/doc_controller_test.rb b/test/functional/doc_controller_test.rb
index 59b6d71d..e89029f3 100644
--- a/test/functional/doc_controller_test.rb
+++ b/test/functional/doc_controller_test.rb
@@ -4,7 +4,7 @@ require File.expand_path('../test_helper', __dir__)
 
 class DocControllerTest < ActionController::TestCase
   test "should get index" do
-    book = FactoryBot.create(:book, code: "en")
+    _book = FactoryBot.create(:book, code: "en")
     get :index
     assert_response :success
   end
@@ -13,7 +13,7 @@ class DocControllerTest < ActionController::TestCase
     file = FactoryBot.create(:doc_file, name: "test-command")
     doc  = FactoryBot.create(:doc, plain: "Doc 1", blob_sha: "d670460b4b4aece5915caf5c68d12f560a9fe3e4")
     vers = FactoryBot.create(:version, name: "v1.0", vorder: Version.version_to_num("1.0"))
-    dver = FactoryBot.create(:doc_version, doc_file: file, version: vers, doc: doc)
+    _dver = FactoryBot.create(:doc_version, doc_file: file, version: vers, doc: doc)
     get :man, params: { file: "test-command" }
     assert_response :success
   end
@@ -22,7 +22,7 @@ class DocControllerTest < ActionController::TestCase
     file = FactoryBot.create(:doc_file, name: "test-command")
     doc  = FactoryBot.create(:doc, plain: "Doc 1", blob_sha: "d670460b4b4aece5915caf5c68d12f560a9fe3e4")
     vers = FactoryBot.create(:version, name: "v1.0", vorder: Version.version_to_num("1.0"))
-    dver = FactoryBot.create(:doc_version, doc_file: file, version: vers, doc: doc)
+    _dver = FactoryBot.create(:doc_version, doc_file: file, version: vers, doc: doc)
     get :man, params: { file: "test-command", version: "v1.0" }
     assert_response :success
   end
@@ -31,7 +31,7 @@ class DocControllerTest < ActionController::TestCase
     file = FactoryBot.create(:doc_file, name: "git-commit")
     doc  = FactoryBot.create(:doc, plain: "Doc 1")
     vers = FactoryBot.create(:version, name: "v1.0")
-    dver = FactoryBot.create(:doc_version, doc_file: file, version: vers, doc: doc)
+    _dver = FactoryBot.create(:doc_version, doc_file: file, version: vers, doc: doc)
     get :man, params: { file: "commit", version: "v1.0" }
     assert_redirected_to "/docs/git-commit"
   end
diff --git a/test/unit/doc_version_test.rb b/test/unit/doc_version_test.rb
index 7cd0f2c4..99b7bb33 100644
--- a/test/unit/doc_version_test.rb
+++ b/test/unit/doc_version_test.rb
@@ -12,7 +12,7 @@ class DocVersionTest < ActiveSupport::TestCase
     file = FactoryBot.create(:doc_file, name: "test-command")
     docs = range.map { |i| FactoryBot.create(:doc, plain: "Doc #{i}") }
     vers = range.map { |i| FactoryBot.create(:version, name: "#{i}.0", vorder: Version.version_to_num("#{i}.0")) }
-    dver = range.map { |i| FactoryBot.create(:doc_version, doc_file: file, version: vers[i], doc: docs[i]) }
+    _dver = range.map { |i| FactoryBot.create(:doc_version, doc_file: file, version: vers[i], doc: docs[i]) }
 
     dv = DocVersion.latest_for("test-command")
     assert_equal docs[3], dv.doc
@@ -23,7 +23,7 @@ class DocVersionTest < ActiveSupport::TestCase
     file = FactoryBot.create(:doc_file, name: "test-command")
     docs = range.map { |i| FactoryBot.create(:doc, plain: "Doc #{i}") }
     vers = range.map { |i| FactoryBot.create(:version, name: "v#{i}.0") }
-    dver = range.map { |i| FactoryBot.create(:doc_version, doc_file: file, version: vers[i], doc: docs[i]) }
+    _dver = range.map { |i| FactoryBot.create(:doc_version, doc_file: file, version: vers[i], doc: docs[i]) }
 
     dv = DocVersion.for_version("test-command", "v2.0")
     assert_equal docs[2], dv.doc