| Age | Commit message (Collapse) | Author |
|---|
|
These are all test scripts that store the results of setup in variables.
Even though they're not used, having them helps make clear what data the
test has available to it, and follows existing patterns.
|
|
|
|
|
|
|
|
Seems reasonable.
|
|
These all seem like reasonable suggestions.
|
|
These are mostly small style fixups, mostly around whitespace. Most of
them look like obvious improvements. A few I could go either way on, but
shutting up rubocop is probably a worthwhile goal.
|
|
This saves us dealing with rubocop issues in them.
|
|
This appeases rubocop Rails/ContentTag.
|
|
This stopped getting called in 2e8fa7e2 (Improve caching for pages and
assets, 2017-02-03), when the functionality was moved to the client
side.
|
|
I can't get this to run on modern ruby/rails. The error looks like this:
.../gems/minitest-5.14.2/lib/minitest.rb:1030:in `run_one_method': BrowsingDocTest#run _must_ return a Result (RuntimeError)
Looks like an incompatibility between minitest and rails-perftest,
according to:
https://github.com/rails/rails-perftest/issues/43
There's even a patch which was merged:
https://github.com/rails/rails-perftest/pull/44
but it looks like never released. I'm not sure I care enough about this
test to wrestle with it further. Comparing perf between versions might
be interesting, but fundamentally we can't _fail_ this in the automated
testing without some kind of baseline. So I don't think it brings much
value to the regression tests.
|
|
Without this, I get errors like:
.../gems/ruby-prof-1.4.2/lib/ruby-prof/printers/call_tree_printer.rb:54:in `print': wrong number of arguments (given 2, expected 0..1) (ArgumentError)
It looks like an incompatibility between rails-perftest and ruby-prof.
This workaround comes from:
https://github.com/rails/rails-perftest/issues/38
|
|
Without this, I get problems with utility methods like have_many being
undefined. I'm not sure if there's a better way to solve this, but this
solution came from:
https://teamtreehouse.com/community/solved-undefined-method-havemany-for-childtestclass-problem-with-shouldamatchers-313
|
|
In newer versions you can no longer pass arbitrary keys like:
get :whatever, foo: bar, baz: bleep
and instead need to group the latter two in a hash under params.
|
|
Newer version of FactoryBot complain about this, and suggest a small
code block.
|
|
The gem has been renamed, so we need to update to match modern versions.
I also seemed to need factory_bot_rails in the gemfile to avoid some
errors.
|
|
|
|
There hasn't been a blog post in 7 years, and there are no
plans to revive it. The existing posts generally fall into
one of two categories:
- news about the pro git book
- technical notes that weren't covered in the 1st edition
of pro git
The former are no longer interesting at all. And the latter
had their content folded into the second edition.
So let's drop this content, as we sometimes get issues
raised about its accuracy and formatting. We want to
redirect people to the actually-maintained book content.
We'll put a short note in the /blog route to help anybody
who follows old links to these posts.
|
|
We haven't been populating the database with this for some
time (and any residual records have been gone for almost a
year due to the database transition). And nobody seems to
have noticed.
Let's just give up on the feature in the name of simplicity.
|
|
|
|
|
|
|
|
|
|
|
|
We can keep adding blog posts by just adding .markdown or .html files to the app/view/blog/posts directory (it was blog/progit before).
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Remove one test for a doc_controller action that doesn't exist. Fix the
other tests by fixing setups and assert.
|
|
Trying to get auto-deploy working. Had to comment out broken tests for
now.
|
|
This allows for shorter URLs like /docs/commit that will redirect to the
correct ones.
|
|
|
|
|
|
* model updates to find the current/specified version of a man page
* controller updates to load up the right doc
* view updates to display the pregenerated HTML
* tests
|
|
|
|
|
|
|
|
|
