diff options
| author | Ashraf Teleb <ashraf.teleb85@gmail.com> | 2022-06-04 00:20:50 +0300 |
|---|---|---|
| committer | Ashraf Teleb <ashraf.teleb85@gmail.com> | 2022-06-04 00:20:50 +0300 |
| commit | 40dcf64e6a51513f988a453e214c1b7ee2d2fc9d (patch) | |
| tree | 5f2b9ef26d044ce385384959c840c6a09b369e51 | |
| parent | 2854ab03cb3ea6394345239aaeb5e84f92aefdf8 (diff) | |
Using non-EV certificate to sign windows binaries (Fixed appx)
| -rw-r--r-- | .github/workflows/electron-builder-win.yml | 8 | ||||
| -rw-r--r-- | electron-builder-appx.json | 1 |
2 files changed, 6 insertions, 3 deletions
diff --git a/.github/workflows/electron-builder-win.yml b/.github/workflows/electron-builder-win.yml index c1638cd..0fc965d 100644 --- a/.github/workflows/electron-builder-win.yml +++ b/.github/workflows/electron-builder-win.yml @@ -10,8 +10,6 @@ jobs: runs-on: windows-latest env: GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} - CSC_LINK: ${{ secrets.WIN_CSC_LINK }} - CSC_KEY_PASSWORD: ${{ secrets.WIN_CSC_KEY_PASSWORD }} steps: - name: Checkout reposistory uses: actions/checkout@v2 @@ -31,12 +29,18 @@ jobs: yarn install cd ../.. - name: Build for Windows (x32) + env: + CSC_LINK: ${{ secrets.WIN_CSC_LINK }} + CSC_KEY_PASSWORD: ${{ secrets.WIN_CSC_KEY_PASSWORD }} shell: powershell #The default shell for Windows run: | #Disable auto-update and build 32bit first such that latest.yml is for 64bit only (64bit will overwrite 32bit one) yarn run sync disableUpdate yarn run release-win32 - name: Build for Windows (x64) + env: + CSC_LINK: ${{ secrets.WIN_CSC_LINK }} + CSC_KEY_PASSWORD: ${{ secrets.WIN_CSC_KEY_PASSWORD }} shell: powershell #The default shell for Windows run: | #Enable auto-update again diff --git a/electron-builder-appx.json b/electron-builder-appx.json index fbf1ded..8c71d49 100644 --- a/electron-builder-appx.json +++ b/electron-builder-appx.json @@ -16,7 +16,6 @@ "provider": "github" }, "win": { - "publisherName": "JGraph Ltd", "target": [ { "target": "appx", |