diff options
author | Jean Lecordier <47030586+jlecordier@users.noreply.github.com> | 2022-02-25 02:10:38 +0300 |
---|---|---|
committer | Jeremy Thomas <bbxdesign@gmail.com> | 2022-05-08 11:26:03 +0300 |
commit | 895b77b3a9c2cfd199b97d2cd602213ee76dac2e (patch) | |
tree | 2731860ead97f63f589314df44b0f9a1d84bccc1 | |
parent | da784b20710aca6eb15de447ff5151536477c527 (diff) |
Remove useless if in js example
If the length is 0, then the forEach call does nothing anyway
Could we remove the slice part as well ? If IE support is required, can’t we just use Array.prototype.forEach ? Can’t we just remove IE support all together to promote clean and up to date code ? Polyfills and code transpilation are here to help support IE
-rw-r--r-- | docs/documentation/components/navbar.html | 24 |
1 files changed, 10 insertions, 14 deletions
diff --git a/docs/documentation/components/navbar.html b/docs/documentation/components/navbar.html index efae333b..f2e64941 100644 --- a/docs/documentation/components/navbar.html +++ b/docs/documentation/components/navbar.html @@ -565,24 +565,20 @@ document.addEventListener('DOMContentLoaded', () => { // Get all "navbar-burger" elements const $navbarBurgers = Array.prototype.slice.call(document.querySelectorAll('.navbar-burger'), 0); - // Check if there are any navbar burgers - if ($navbarBurgers.length > 0) { + // Add a click event on each of them + $navbarBurgers.forEach( el => { + el.addEventListener('click', () => { - // Add a click event on each of them - $navbarBurgers.forEach( el => { - el.addEventListener('click', () => { + // Get the target from the "data-target" attribute + const target = el.dataset.target; + const $target = document.getElementById(target); - // Get the target from the "data-target" attribute - const target = el.dataset.target; - const $target = document.getElementById(target); - - // Toggle the "is-active" class on both the "navbar-burger" and the "navbar-menu" - el.classList.toggle('is-active'); - $target.classList.toggle('is-active'); + // Toggle the "is-active" class on both the "navbar-burger" and the "navbar-menu" + el.classList.toggle('is-active'); + $target.classList.toggle('is-active'); - }); }); - } + }); }); {% endcapture %} |