Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/llvm/llvm-project.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
path: root/bolt
AgeCommit message (Collapse)Author
2022-03-12[BOLT][NFC] Use getShortOpcodeArith in X86MCPlusBuilderAmir Ayupov
Unify `llvm::X86::getRelaxedOpcodeArith` and `getShortArithOpcode` in X86MCPlusBuilder.cpp. Addresses https://lists.llvm.org/pipermail/llvm-dev/2022-January/154526.html Reviewed By: rafauler Differential Revision: https://reviews.llvm.org/D121404
2022-03-12[CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLEPetr Hosek
This clarifies that this is an LLVM specific variable and avoids potential conflicts with other projects. Differential Revision: https://reviews.llvm.org/D119918
2022-03-10[BOLT] Divide RegularPageSize for X86 and AArch64 casesElvina Yakubova
For AArch64 in some cases/some distributions ld uses 64K alignment of LOAD segments by default. Reviewed By: yota9, maksfb Differential Revision: https://reviews.llvm.org/D119267
2022-03-10[BOLT] LongJmp: Use per-function alignment valuesVladislav Khmelevsky
The per-function alignment values must be used in order to create tentative layout. Differential Revision: https://reviews.llvm.org/D121298
2022-03-10[BOLT][NFC] Fix print-cfg data raceAmir Ayupov
Addresses ThreadSanitizer warning Reviewed By: rafauler Differential Revision: https://reviews.llvm.org/D121337
2022-03-10[BOLT][NFC] Check errors from Obj.dynamicEntriesAmir Ayupov
Addresses fuzzer crash Reviewed By: rafauler Differential Revision: https://reviews.llvm.org/D121336
2022-03-09[BOLT] Move some of the tests to common directoryVladislav Khmelevsky
Some of the tests are not x86-specific, move them to common directory. Differential Revision: https://reviews.llvm.org/D121261
2022-03-09[BOLT] Handle ifuncs trampolines for aarch64Vladislav Khmelevsky
The aarch64 uses the trampolines located in .iplt section, which contains plt-like trampolines on the value stored in .got. In this case we don't have JUMP_SLOT relocation, but we have a symbol that belongs to ifunc trampoline, so use it and set set plt symbol for such functions. Vladislav Khmelevsky, Advanced Software Technology Lab, Huawei Differential Revision: https://reviews.llvm.org/D120850
2022-03-09[BOLT][NFC] Handle "dynamic section sizes should match"Amir Ayupov
Address fuzzer crash on malformed input Reviewed By: rafauler Differential Revision: https://reviews.llvm.org/D121070
2022-03-08[BOLT] CMOVConversion passAmir Ayupov
Convert simple hammocks into cmov based on misprediction rate. Test Plan: - Assembly test: `cmov-conversion.s` - Testing on a binary: # Bootstrap clang with `-x86-cmov-converter-force-all` and `-Wl,--emit-relocs` (Release build) # Collect perf.data: - `clang++ <opts> bolt/lib/Core/BinaryFunction.cpp -E > bf.cpp` - `perf record -e cycles:u -j any,u -- clang-15 bf.cpp -O2 -std=c++14 -c -o bf.o` # Optimize clang-15 with and w/o -cmov-conversion: - `llvm-bolt clang-15 -p perf.data -o clang-15.bolt` - `llvm-bolt clang-15 -p perf.data -cmov-conversion -o clang-15.bolt.cmovconv` # Run perf experiment: - test: `clang-15.bolt.cmovconv`, - control: `clang-15.bolt`, - workload (clang options): `bf.cpp -O2 -std=c++14 -c -o bf.o` Results: ``` task-clock [delta: -360.21 ± 356.75, delta(%): -1.7760 ± 1.7589, p-value: 0.047951, balance: -6] instructions [delta: 44061118 ± 13246382, delta(%): 0.0690 ± 0.0207, p-value: 0.000001, balance: 50] icache-misses [delta: -5534468 ± 2779620, delta(%): -0.4331 ± 0.2175, p-value: 0.028014, balance: -28] branch-misses [delta: -1624270 ± 1113244, delta(%): -0.3456 ± 0.2368, p-value: 0.030300, balance: -22] ``` Reviewed By: rafauler Differential Revision: https://reviews.llvm.org/D120177
2022-03-08[BOLT][NFC] Check section contents before registering itAmir Ayupov
Address fuzzer crash on malformed input: ``` BOLT-ERROR: cannot get section contents for .dynsym: The end of the file was unexpectedly encountered. ``` Reviewed By: rafauler Differential Revision: https://reviews.llvm.org/D121068
2022-03-08[BOLT][CMAKE] Remove CMake 3.13.4 incompatible parameterAmir Ayupov
Remove `TYPE BIN` parameter that is introduced in CMake 3.14 and revert back to the equivalent compatible form `DESTINATION ${CMAKE_INSTALL_BINDIR}`. Addresses https://github.com/llvm/llvm-project/issues/54099 Reviewed By: rafauler Differential Revision: https://reviews.llvm.org/D121012
2022-03-07Revert "Add CMake option not to build BOLT tests"Yi Kong
This reverts commit d8f4d54664171bac46e6c8446df04850b40cc4f7. Merged by accident.
2022-03-07Add CMake option not to build BOLT testsYi Kong
2022-03-04[BOLT][NFC] Return MCRegister::NoRegister from MCPlusBuilder::getNoRegister()Maksim Panchenko
Reviewed By: yota9 Differential Revision: https://reviews.llvm.org/D120863
2022-03-02[BOLT] Enable PLT analysis for aarch64Vladislav Khmelevsky
This patch enables PLT analysis for aarch64. It is used by the static relocations in order to provide final symbol address of PLT entry for some instructions like ADRP. Vladislav Khmelevsky, Advanced Software Technology Lab, Huawei Differential Revision: https://reviews.llvm.org/D118088
2022-03-02[BOLT][test] Fix function size in test caseMaksim Panchenko
2022-03-01[BOLT] Fix X86MCPlusBuilder::replaceRegWithImmAmir Ayupov
Reassigning the operand didn't update the operand type which resulted in an assertion (`Assertion `isReg() && "This is not a register operand!"' failed.`) Reset the instruction instead. Test Plan: ``` ninja check-bolt ... PASS: BOLT-Unit :: Core/./CoreTests/X86/MCPlusBuilderTester.ReplaceRegWithImm/0 (90 of 136) ``` Reviewed By: rafauler Differential Revision: https://reviews.llvm.org/D120263
2022-02-25[BOLT][DWARF] Fix how DW_AT_high_pc [DW_FORM_udata] is handledAlexander Yermolovich
We were not handling correctly conversion from DW_AT_high_pc into DW_AT_ranges, when size of DW_AT_high_pc is not 4/8 bytes. Reviewed By: maksfb Differential Revision: https://reviews.llvm.org/D120528
2022-02-24[BOLT] Support PC-relative relocations with addendsMaksim Panchenko
PC-relative memory operand could reference a different object from the one located at the target address, e.g. when a negative offset is used. Check relocations for the real referenced object. Reviewed By: rafauler Differential Revision: https://reviews.llvm.org/D120379
2022-02-24[BOLT][NFC] Report errors from RewriteInstance `discoverStorage` and `run`Amir Ayupov
Further improve error handling in BOLT by reporting `RewriteInstance` errors in a library and fuzzer-friendly way instead of exiting. Follow-up to D119658 Reviewed By: rafauler Differential Revision: https://reviews.llvm.org/D120224
2022-02-24[BOLT][NFC] Fix undefined behavior in encodeAnnotationImmAmir Ayupov
Fix UBSan-reported issue in MCPlusBuilder::encodeAnnotationImm (left shift of a negative value). Test Plan: ``` ninja check-bolt ... PASS: BOLT-Unit :: Core/./CoreTests/AArch64/MCPlusBuilderTester.Annotation/0 (1 of 140) PASS: BOLT-Unit :: Core/./CoreTests/X86/MCPlusBuilderTester.Annotation/0 (131 of 134) ``` Reviewed By: maksfb, yota9 Differential Revision: https://reviews.llvm.org/D120260
2022-02-23[BOLT][DWARF] Remove patchLowHigh unused function.Alexander Yermolovich
Cleanup after removing caching mechanims for ranges/abbrevs. Reviewed By: rafauler, yota9 Differential Revision: https://reviews.llvm.org/D120174
2022-02-21[BOLT] Added fuzzer target (llvm-bolt-fuzzer)Amir Ayupov
This adds a target that would consume random binary as an input ELF file. TBD: add structured input support (ELF). Build: ``` cmake /path/to/llvm-project/llvm -GNinja \ -DLLVM_TARGETS_TO_BUILD="X86;AArch64" \ -DCMAKE_BUILD_TYPE=Release \ -DLLVM_ENABLE_ASSERTIONS=1 \ -DCMAKE_C_COMPILER=<sanitizer-capable clang> \ -DCMAKE_CXX_COMPILER=<sanitizer-capable clang++> \ -DLLVM_ENABLE_PROJECTS="bolt" \ -DLLVM_USE_SANITIZER=Address \ -DLLVM_USE_SANITIZE_COVERAGE=On ninja llvm-bolt-fuzzer ``` Test Plan: ninja llvm-bolt-fuzzer Reviewed By: maksfb Differential Revision: https://reviews.llvm.org/D120016
2022-02-21[BOLT][NFC] Fix data race in ShrinkWrapping statsAmir Ayupov
Fix data race reported by ThreadSanitizer in clang.test: ``` ThreadSanitizer: data race /data/llvm-project/bolt/lib/Passes/ShrinkWrapping.cpp:1359:28 in llvm::bolt::ShrinkWrapping::moveSaveRestores() ``` The issue is with incrementing global counters from multiple threads. Reviewed By: yota9 Differential Revision: https://reviews.llvm.org/D120218
2022-02-17[BOLT][NFC] Report errors from createBinaryContext and RewriteInstance ctorAmir Ayupov
Refactor createBinaryContext and RewriteInstance/MachORewriteInstance constructors to report an error in a library and fuzzer-friendly way instead of returning a nullptr or exiting. Reviewed By: rafauler Differential Revision: https://reviews.llvm.org/D119658
2022-02-16[BOLT] Update dynamic relocations from section relocationsVladislav Khmelevsky
This patch changes patchELFAllocatableRelaSections from going through old relocations sections and update the relocation offsets to emitting the relocations stored in binary sections. This is needed in case we would like to remove and add dynamic relocations during BOLT work and it is used by golang support pass. Note: Currently we emit relocations in the old sections, so the total number of them should be equal or less of old number. Testing: No special tests are neeeded, since this patch does not fix anything or add new functionality (it only prepares to add). Every PIC-compiled test binary will use this code and thus become a test. But just in case the aarch64 dynamic relocations tests were added. Vladislav Khmelevsky, Advanced Software Technology Lab, Huawei Reviewed By: maksfb Differential Revision: https://reviews.llvm.org/D117612
2022-02-16[NFC][MC] remove unused argument `MCRegisterInfo` in `MCCodeEmitter`Shao-Ce SUN
Reviewed By: skan Differential Revision: https://reviews.llvm.org/D119846
2022-02-16Revert "[NFC][MC] remove unused argument `MCRegisterInfo` in `MCCodeEmitter`"Shao-Ce SUN
This reverts commit fe25c06cc5bdc2ef9427309f8ec1434aad69dc7a.
2022-02-16[NFC][MC] remove unused argument `MCRegisterInfo` in `MCCodeEmitter`Shao-Ce SUN
For ten years, it seems that `MCRegisterInfo` is not used by any target. Reviewed By: skan Differential Revision: https://reviews.llvm.org/D119846
2022-02-16[BOLT][DWARF] Add ability to insert new entries in to DIEAlexander Yermolovich
Added ability to append new entries to DIE. This is useful to standadize DWARF4 Split Dwarf, and simplify implementation of DWARF5. Multiple DIEs can share an abbrev. So currently limitation is that only unique Attributes can be added. Reviewed By: maksfb Differential Revision: https://reviews.llvm.org/D119577
2022-02-15[BOLT] Fix aarch64 dwarf testVladislav Khmelevsky
After "Remove caching of ranges/abbrevs" patch the dwarf offsets are a bit changed and the subprograms high pc is replaced with AT_RANGES. Reviewed By: rafauler Differential Revision: https://reviews.llvm.org/D119733
2022-02-15Cleanup LLVMDWARFDebugInfoserge-sans-paille
As usual with that header cleanup series, some implicit dependencies now need to be explicit: llvm/DebugInfo/DWARF/DWARFContext.h no longer includes: - "llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h" - "llvm/DebugInfo/DWARF/DWARFCompileUnit.h" - "llvm/DebugInfo/DWARF/DWARFDebugAbbrev.h" - "llvm/DebugInfo/DWARF/DWARFDebugAranges.h" - "llvm/DebugInfo/DWARF/DWARFDebugFrame.h" - "llvm/DebugInfo/DWARF/DWARFDebugLoc.h" - "llvm/DebugInfo/DWARF/DWARFDebugMacro.h" - "llvm/DebugInfo/DWARF/DWARFGdbIndex.h" - "llvm/DebugInfo/DWARF/DWARFSection.h" - "llvm/DebugInfo/DWARF/DWARFTypeUnit.h" - "llvm/DebugInfo/DWARF/DWARFUnitIndex.h" Plus llvm/Support/Errc.h not included by a bunch of llvm/DebugInfo/DWARF/DWARF*.h files Preprocessed lines to build llvm on my setup: after: 1065629059 before: 1066621848 Which is a great diff! Discourse thread: https://discourse.llvm.org/t/include-what-you-use-include-cleanup Differential Revision: https://reviews.llvm.org/D119723
2022-02-14[BOLT] Make order of jump table successors deterministicMaksim Panchenko
When a jump table is recovered in postProcessIndirectBranches(), successors for the containing basic block are added in random order. Make the order deterministic. Reviewed By: yota9 Differential Revision: https://reviews.llvm.org/D119672
2022-02-14[BOLT] Skip warning message if no functions were ignoredMaksim Panchenko
Reviewed By: yota9, Amir Differential Revision: https://reviews.llvm.org/D119673
2022-02-10Cleanup LLVMObject headersserge-sans-paille
Most notably, llvm/Object/Binary.h no longer includes llvm/Support/MemoryBuffer.h llvm/Object/MachOUniversal*.h no longer include llvm/Object/Archive.h llvm/Object/TapiUniversal.h no longer includes llvm/Object/TapiFile.h llvm-project preprocessed size: before: 1068185081 after: 1068324320 Discourse thread: https://discourse.llvm.org/t/include-what-you-use-include-cleanup Differential Revision: https://reviews.llvm.org/D119457
2022-02-10Update all LLVM documentation mentioning runtimes in LLVM_ENABLE_PROJECTSLouis Dionne
We are moving away from building the runtimes with LLVM_ENABLE_PROJECTS, however the documentation was largely outdated. This commit updates all the documentation I could find to use LLVM_ENABLE_RUNTIMES instead of LLVM_ENABLE_PROJECTS for building runtimes. Note that in the near future, libcxx, libcxxabi and libunwind will stop supporting being built with LLVM_ENABLE_PROJECTS altogether. I don't know what the plans are for other runtimes like libc, openmp and compiler-rt, so I didn't make any changes to the documentation that would imply something for those projects. Once this lands, I will also cherry-pick this on the release/14.x branch to make sure that LLVM's documentation is up-to-date and reflects what we intend to support in the future. Differential Revision: https://reviews.llvm.org/D119351
2022-02-09Add missing MC includes in bolt/serge-sans-paille
Changes needed after ef736a1c39f27ef4 that removes some implicit dependencies from MrCV headers.
2022-02-09[BOLT][DWARF] Remove caching of ranges/abbrevsAlexander Yermolovich
Removing caching of ranges/abbrevs to simplify the code. Before we were doing it to get around a gdb limitation. FBD34015613 Reviewed By: Amir, maksfb Differential Revision: https://reviews.llvm.org/D119276
2022-02-08[BOLT][TEST] Add .so instrumentation testAmir Ayupov
Summary: Shared object instrumentation test Test Plan: bin/llvm-lit -a bolt/test/X86/internal-call-instrument-so.s Reviewers: rafauler FBD34064557
2022-02-08[BOLT][CMAKE][NFC] Update runtime/CMakeLists.txtAmir Ayupov
Summary: - Specify compiler flags for runtime libraries as BOLT_RT_FLAGS, - Remove redundant CMake definitions. Reviewers: maksfb FBD34048561
2022-02-08[BOLT] Add ld.lld substitutionAmir Ayupov
Register ld.lld substition (tests were failing) Reviewed By: yota9 Differential Revision: https://reviews.llvm.org/D118738
2022-02-08[BOLT] Fix runtime osx cross-compile buildVladislav Khmelevsky
Place include elf.h under !apple condition Differential Revision: https://reviews.llvm.org/D119038
2022-02-08[BOLT] Add aarch64 support for peephole passesVladislav Khmelevsky
Enable peephole optimizations for aarch64. Also small code refactoring - add PeepholeOpts under Peepholes class. Vladislav Khmelevsky, Advanced Software Technology Lab, Huawei Differential Revision: https://reviews.llvm.org/D118732
2022-02-07[BOLT] Refactor heatmap to be standalone toolVladislav Khmelevsky
Separate heatmap from bolt and build it as standalone tool. Reviewed By: maksfb Differential Revision: https://reviews.llvm.org/D118946
2022-02-05[BOLT] Add nfc-check-setup scriptAmir Ayupov
Add the script to set up llvm-bolt-wrapper. The intended use is to run NFC checks manually and automatically on a buildbot. Reviewed By: rafauler Differential Revision: https://reviews.llvm.org/D118516
2022-02-05[BOLT-UnitTests] Fix shared libraries buildAmir Ayupov
Fix build with `-DBUILD_SHARED_LIBS=ON` (add explicit deps). Reviewed By: yota9 Differential Revision: https://reviews.llvm.org/D119042
2022-02-05[BOLT][NFC] Fix compiler warningsAmir Ayupov
Summary: - variable 'TotalSize' set but not used - variable 'TotalCallsTopN' set but not used - use of bitwise '|' with boolean operands Reviewed By: maksfb FBD33911129
2022-02-04[BOLT][TEST] Add section flags for .gcc_except_tableAmir Ayupov
clang-10 complains about changed section flags in two tests: - X86/shrinkwrapping.test - X86/exceptions-args.test Fix that by adding the missing flags. Reviewed By: yota9 Differential Revision: https://reviews.llvm.org/D119014
2022-02-03[BOLT][NFC] Use isInt<> instead of range checksAmir Ayupov
Summary: Reuse LLVM isInt check Reviewed By: maksfb FBD33945182
generated by cgit v1.2.3 (git 2.25.1) at 2024-08-27 02:52:30 +0300