Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/mapsme/omim.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorvng <viktor.govako@gmail.com>2013-03-24 20:59:52 +0400
committerAlex Zolotarev <alex@maps.me>2015-09-23 01:52:19 +0300
commit0aab73732755eae8c5e35516c7891175d172fe10 (patch)
treef0ca8f95556c66c42f909aa58979847218044b95 /android
parent6ae525bdd01d013e60f492e3ffdfbbc4b4db8a0b (diff)
[android] Code style fix according to code review.
Diffstat (limited to 'android')
-rw-r--r--android/src/com/mapswithme/maps/bookmarks/BookmarkActivity.java13
-rw-r--r--android/src/com/mapswithme/maps/bookmarks/ChooseBookmarkCategoryActivity.java4
2 files changed, 10 insertions, 7 deletions
diff --git a/android/src/com/mapswithme/maps/bookmarks/BookmarkActivity.java b/android/src/com/mapswithme/maps/bookmarks/BookmarkActivity.java
index 108ccf5272..7ccc6bc8ab 100644
--- a/android/src/com/mapswithme/maps/bookmarks/BookmarkActivity.java
+++ b/android/src/com/mapswithme/maps/bookmarks/BookmarkActivity.java
@@ -42,7 +42,7 @@ public class BookmarkActivity extends AbstractBookmarkActivity
private List<Icon> mIcons;
private ImageView mChooserImage;
private EditText mDescr;
- private Icon m_icon = null;
+ private Icon mIcon = null;
@Override
public void onCreate(Bundle savedInstanceState)
@@ -51,10 +51,11 @@ public class BookmarkActivity extends AbstractBookmarkActivity
setContentView(R.layout.add_or_edit_bookmark);
+ // Note that Point result from the intent is actually a pair of (category index, bookmark index in category).
assert(getIntent().getExtras().containsKey(PIN));
- final Point p = ((ParcelablePoint)getIntent().getParcelableExtra(PIN)).getPoint();
+ final Point cab = ((ParcelablePoint)getIntent().getParcelableExtra(PIN)).getPoint();
- mPin = mManager.getBookmark(p.x, p.y);
+ mPin = mManager.getBookmark(cab.x, cab.y);
mCurrentCategoryId = mPin.getCategoryId();
setTitle(mPin.getName());
@@ -63,8 +64,8 @@ public class BookmarkActivity extends AbstractBookmarkActivity
private void updateColorChooser(Icon icon)
{
- m_icon = icon;
- mChooserImage.setImageBitmap(m_icon.getIcon());
+ mIcon = icon;
+ mChooserImage.setImageBitmap(mIcon.getIcon());
}
private void refreshValuesInViews()
@@ -136,7 +137,7 @@ public class BookmarkActivity extends AbstractBookmarkActivity
private void assignPinParams()
{
if (mPin != null)
- mPin.setParams(mName.getText().toString(), m_icon, mDescr.getText().toString());
+ mPin.setParams(mName.getText().toString(), mIcon, mDescr.getText().toString());
}
@Override
diff --git a/android/src/com/mapswithme/maps/bookmarks/ChooseBookmarkCategoryActivity.java b/android/src/com/mapswithme/maps/bookmarks/ChooseBookmarkCategoryActivity.java
index 884579c1e4..16ffb807fc 100644
--- a/android/src/com/mapswithme/maps/bookmarks/ChooseBookmarkCategoryActivity.java
+++ b/android/src/com/mapswithme/maps/bookmarks/ChooseBookmarkCategoryActivity.java
@@ -43,7 +43,8 @@ public class ChooseBookmarkCategoryActivity extends AbstractBookmarkCategoryActi
m_handler.switchToAddButton();
mAdapter.chooseItem(position);
- Point cab = ((ParcelablePoint)getIntent().getParcelableExtra(BookmarkActivity.PIN)).getPoint();
+ // Note that Point result from the intent is actually a pair of (category index, bookmark index in category).
+ final Point cab = ((ParcelablePoint)getIntent().getParcelableExtra(BookmarkActivity.PIN)).getPoint();
Bookmark bmk = mManager.getBookmark(cab.x, cab.y);
bmk.setCategoryId(position);
getIntent().putExtra(BookmarkActivity.PIN, new ParcelablePoint(position, bmk.getBookmarkId()));
@@ -160,6 +161,7 @@ public class ChooseBookmarkCategoryActivity extends AbstractBookmarkCategoryActi
private void createNewCategory(String name)
{
+ // Note that Point result from the intent is actually a pair of (category index, bookmark index in category).
final Point cab = ((ParcelablePoint)getIntent().getParcelableExtra(BookmarkActivity.PIN)).getPoint();
final int index = mManager.createCategory(mManager.getBookmark(cab.x, cab.y), name);