diff options
author | Maxim Pimenov <m@maps.me> | 2019-04-15 17:47:05 +0300 |
---|---|---|
committer | Arsentiy Milchakov <milcars@mapswithme.com> | 2019-04-15 21:01:06 +0300 |
commit | 1d0428d056aa2e6b0024f991991f5c513cff9f73 (patch) | |
tree | cff44256529314ec8fcc9ea22fab87520a76e33a /coding | |
parent | 25087ac0bf7e8c41e0d0684e43b5285a8b8be47c (diff) |
Several explicit constructors per the Cppcheck report.
Diffstat (limited to 'coding')
-rw-r--r-- | coding/coding_tests/uri_test.cpp | 2 | ||||
-rw-r--r-- | coding/mmap_reader.cpp | 2 | ||||
-rw-r--r-- | coding/zip_creator.cpp | 2 | ||||
-rw-r--r-- | coding/zip_reader.cpp | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/coding/coding_tests/uri_test.cpp b/coding/coding_tests/uri_test.cpp index a2aa541034..2e7619b216 100644 --- a/coding/coding_tests/uri_test.cpp +++ b/coding/coding_tests/uri_test.cpp @@ -19,7 +19,7 @@ namespace class TestUri { public: - TestUri(string const & uri) { m_uri = uri; } + explicit TestUri(string const & uri) { m_uri = uri; } TestUri & Scheme(string const &scheme) { m_scheme = scheme; return *this; } TestUri & Path(string const & path) { m_path = path; return *this; } TestUri & KV(string const & key, string const & value) diff --git a/coding/mmap_reader.cpp b/coding/mmap_reader.cpp index dd78d3103a..6d4dc0aaef 100644 --- a/coding/mmap_reader.cpp +++ b/coding/mmap_reader.cpp @@ -26,7 +26,7 @@ public: uint8_t * m_memory; uint64_t m_size; - MmapData(string const & fileName) + explicit MmapData(string const & fileName) { // @TODO add windows support #ifndef OMIM_OS_WINDOWS diff --git a/coding/zip_creator.cpp b/coding/zip_creator.cpp index 7b68a5ac9e..8a6bbd9d72 100644 --- a/coding/zip_creator.cpp +++ b/coding/zip_creator.cpp @@ -26,7 +26,7 @@ class ZipHandle zipFile m_zipFileHandle; public: - ZipHandle(string const & filePath) + explicit ZipHandle(string const & filePath) { m_zipFileHandle = zipOpen(filePath.c_str(), 0); } diff --git a/coding/zip_reader.cpp b/coding/zip_reader.cpp index 18ee1a4cfa..114d5d9037 100644 --- a/coding/zip_reader.cpp +++ b/coding/zip_reader.cpp @@ -14,7 +14,7 @@ namespace class UnzipFileDelegate : public ZipFileReader::Delegate { public: - UnzipFileDelegate(string const & path) + explicit UnzipFileDelegate(string const & path) : m_file(make_unique<FileWriter>(path)), m_path(path), m_completed(false) { } |