Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/mapsme/omim.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAnatoly Serdtcev <serdtcev@maps.me>2019-04-03 18:47:16 +0300
committerAnatoly Serdtcev <serdtcev@maps.me>2019-04-03 18:47:16 +0300
commit88f936a9266e7d95b45d7145e07d73cfbeb7e618 (patch)
treee54eb0673eb5a9f75fb50b535354873bf18bccdd /generator
parent61672cbf8fa6e2a7c520ea8c1383ff1873066205 (diff)
[generator:regions] Fix for review
Diffstat (limited to 'generator')
-rw-r--r--generator/generator_tests/regions_tests.cpp2
-rw-r--r--generator/place_node.hpp4
-rw-r--r--generator/regions/regions.cpp4
3 files changed, 5 insertions, 5 deletions
diff --git a/generator/generator_tests/regions_tests.cpp b/generator/generator_tests/regions_tests.cpp
index f875436684..e1a3cca236 100644
--- a/generator/generator_tests/regions_tests.cpp
+++ b/generator/generator_tests/regions_tests.cpp
@@ -199,7 +199,7 @@ UNIT_TEST(RegionsBuilderTest_GetCountryTrees)
RegionsBuilder builder(MakeTestDataSet1(collector));
builder.ForEachNormalizedCountry([&](std::string const & name, Node::Ptr const & tree) {
Visit(tree, [&](Node::Ptr const & node) {
- auto path = MakeNodePath(node);
+ auto const path = MakeNodePath(node);
StringJoinPolicy stringifier;
bankOfNames.push_back(stringifier.ToString(path));
});
diff --git a/generator/place_node.hpp b/generator/place_node.hpp
index 5f4bfb97c0..e3f6a101c6 100644
--- a/generator/place_node.hpp
+++ b/generator/place_node.hpp
@@ -47,8 +47,8 @@ private:
template <typename Data, typename Visitor>
void Visit(std::shared_ptr<PlaceNode<Data>> const & tree, Visitor && visitor)
{
- std::forward<Visitor>(visitor)(tree);
+ visitor(tree);
for (auto const & subtree : tree->GetChildren())
- Visit(subtree, std::forward<Visitor>(visitor));
+ Visit(subtree, visitor);
}
} // namespace generator
diff --git a/generator/regions/regions.cpp b/generator/regions/regions.cpp
index fa7cea1182..8595b1afc0 100644
--- a/generator/regions/regions.cpp
+++ b/generator/regions/regions.cpp
@@ -80,8 +80,8 @@ private:
auto jsonPolicy = JsonPolicy{m_verbose};
Visit(tree, [&](auto && node) {
- auto id = node->GetData().GetId();
- auto path = MakeNodePath(node);
+ auto const id = node->GetData().GetId();
+ auto const path = MakeNodePath(node);
regionsKv << static_cast<int64_t>(id.GetEncodedId()) << " " << jsonPolicy.ToString(path) << "\n";
++countIds;
if (!setIds.insert(id).second)