diff options
author | Sergey Magidovich <mgsergio@mapswithme.com> | 2016-06-03 13:52:14 +0300 |
---|---|---|
committer | Sergey Magidovich <mgsergio@mapswithme.com> | 2016-06-03 15:36:21 +0300 |
commit | ce64dac110b8d0e1994b2f46f5bbd5e10142fd67 (patch) | |
tree | 787640beba8b925a5786227d485804bfc38e0749 /map | |
parent | 47e1a0e317d6ab28e32f4a295f9b9af7697681b1 (diff) |
Code review.
Diffstat (limited to 'map')
-rw-r--r-- | map/framework.cpp | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/map/framework.cpp b/map/framework.cpp index e6caa75420..def6156fb8 100644 --- a/map/framework.cpp +++ b/map/framework.cpp @@ -735,7 +735,7 @@ void Framework::FillInfoFromFeatureType(FeatureType const & ft, place_page::Info { auto const featureStatus = osm::Editor::Instance().GetFeatureStatus(ft.GetID()); ASSERT_NOT_EQUAL(featureStatus, osm::Editor::FeatureStatus::Deleted, - ("Deleted features cannot be selected from UI")); + ("Deleted features cannot be selected from UI.")); info.SetFromFeatureType(ft); if (ftypes::IsAddressObjectChecker::Instance()(ft)) @@ -1757,7 +1757,7 @@ bool Framework::ShowMapForURL(string const & url) if (result != FAILED) { // Always hide current map selection. - DeactivateMapSelection(true); + DeactivateMapSelection(true /* notifyUI */); // set viewport and stop follow mode if any StopLocationFollow(); @@ -2000,7 +2000,7 @@ void Framework::OnTapEvent(df::TapInfo const & tapInfo) alohalytics::Stats::Instance().LogEvent(somethingWasAlreadySelected ? "$DelectMapObject" : "$EmptyTapOnMap"); // UI is always notified even if empty map is tapped, // because empty tap event switches on/off full screen map view mode. - DeactivateMapSelection(true); + DeactivateMapSelection(true /* notifyUI */); } } @@ -2900,7 +2900,7 @@ bool Framework::RollBackChanges(FeatureID const & fid) if (rolledBack) { if (status == osm::Editor::FeatureStatus::Created) - DeactivateMapSelection(true); + DeactivateMapSelection(true /* notifyUI */); else UpdatePlacePageInfoForCurrentSelection(); } @@ -2908,9 +2908,9 @@ bool Framework::RollBackChanges(FeatureID const & fid) } void Framework::CreateNote(ms::LatLon const & latLon, FeatureID const & fid, - osm::Editor::NoteProblemType const type, string const & note) + osm::Editor::NoteProblemType const type, string const & note) { osm::Editor::Instance().CreateNote(latLon, fid, type, note); if (type == osm::Editor::NoteProblemType::PlaceDoesNotExist) - DeactivateMapSelection(true); + DeactivateMapSelection(true /* notifyUI */); } |