diff options
| author | Arsentiy Milchakov <milcars@mapswithme.com> | 2018-09-05 17:45:27 +0300 |
|---|---|---|
| committer | Roman Kuznetsov <r.kuznetsow@gmail.com> | 2018-09-05 17:56:51 +0300 |
| commit | 4c14c4b3fa399ff79e83e0f043ccd592c92a8339 (patch) | |
| tree | daaf147340f4d3a74b26e5c49ab44f307d615c9d /metrics | |
| parent | 2ac5023f787ec9f801b57de0fdb6eba6ae2aecb0 (diff) | |
[eye][tips] review fixes
Diffstat (limited to 'metrics')
| -rw-r--r-- | metrics/eye_info.hpp | 6 | ||||
| -rw-r--r-- | metrics/metrics_tests/eye_tests.cpp | 8 |
2 files changed, 7 insertions, 7 deletions
diff --git a/metrics/eye_info.hpp b/metrics/eye_info.hpp index 66e67592e4..b0ef53b267 100644 --- a/metrics/eye_info.hpp +++ b/metrics/eye_info.hpp @@ -110,7 +110,7 @@ struct Discovery struct Layer { - enum Type + enum class Type : uint8_t { TrafficJams, PublicTransport @@ -135,7 +135,7 @@ struct Tip BookmarksCatalog, BookingHotels, DiscoverButton, - MapsLayers, + PublicTransport, Count }; @@ -181,7 +181,7 @@ inline std::string DebugPrint(Tip::Type const & type) case Tip::Type::BookmarksCatalog: return "BookmarksCatalog"; case Tip::Type::BookingHotels: return "BookingHotels"; case Tip::Type::DiscoverButton: return "DiscoverButton"; - case Tip::Type::MapsLayers: return "MapsLayers"; + case Tip::Type::PublicTransport: return "PublicTransport"; case Tip::Type::Count: return "Count"; } } diff --git a/metrics/metrics_tests/eye_tests.cpp b/metrics/metrics_tests/eye_tests.cpp index 6e01004c41..2c927c2b2b 100644 --- a/metrics/metrics_tests/eye_tests.cpp +++ b/metrics/metrics_tests/eye_tests.cpp @@ -118,7 +118,7 @@ UNIT_CLASS_TEST(ScopedEyeForTesting, AppendTipTest) Time prevShowTime; { - EyeForTesting::AppendTip(Tip::Type::MapsLayers, Tip::Event::ActionClicked); + EyeForTesting::AppendTip(Tip::Type::PublicTransport, Tip::Event::ActionClicked); auto const info = Eye::Instance().GetInfo(); auto const & tips = info->m_tips; @@ -126,7 +126,7 @@ UNIT_CLASS_TEST(ScopedEyeForTesting, AppendTipTest) TEST_EQUAL(tips.size(), 2, ()); TEST_NOT_EQUAL(tips[1].m_lastShownTime.time_since_epoch().count(), 0, ()); - TEST_EQUAL(tips[1].m_type, Tip::Type::MapsLayers, ()); + TEST_EQUAL(tips[1].m_type, Tip::Type::PublicTransport, ()); TEST_EQUAL(tips[1].m_eventCounters.Get(Tip::Event::GotitClicked), 0, ()); TEST_EQUAL(tips[1].m_eventCounters.Get(Tip::Event::ActionClicked), 1, ()); TEST_NOT_EQUAL(lastShownTipTime.time_since_epoch().count(), 0, ()); @@ -135,7 +135,7 @@ UNIT_CLASS_TEST(ScopedEyeForTesting, AppendTipTest) prevShowTime = lastShownTipTime; } { - EyeForTesting::AppendTip(Tip::Type::MapsLayers, Tip::Event::GotitClicked); + EyeForTesting::AppendTip(Tip::Type::PublicTransport, Tip::Event::GotitClicked); auto const info = Eye::Instance().GetInfo(); auto const & tips = info->m_tips; @@ -143,7 +143,7 @@ UNIT_CLASS_TEST(ScopedEyeForTesting, AppendTipTest) TEST_EQUAL(tips.size(), 2, ()); TEST_NOT_EQUAL(tips[1].m_lastShownTime.time_since_epoch().count(), 0, ()); - TEST_EQUAL(tips[1].m_type, Tip::Type::MapsLayers, ()); + TEST_EQUAL(tips[1].m_type, Tip::Type::PublicTransport, ()); TEST_EQUAL(tips[1].m_eventCounters.Get(Tip::Event::GotitClicked), 1, ()); TEST_EQUAL(tips[1].m_eventCounters.Get(Tip::Event::ActionClicked), 1, ()); TEST_NOT_EQUAL(lastShownTipTime.time_since_epoch().count(), 0, ()); |