Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/mapsme/omim.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorr.kuznetsov <r.kuznetsov@corp.mail.ru>2019-05-28 11:17:52 +0300
committerArsentiy Milchakov <milcars@mapswithme.com>2019-05-28 12:28:02 +0300
commitd7bae8db7be0caef823e04cdd980ac7db23ee193 (patch)
treec2925d2f26d5e3c11ae4e152f09a8b5ee0ce74cb /partners_api
parentb3618bd893977410ad87b2865d8e9144404dbd8c (diff)
Review fixes
Diffstat (limited to 'partners_api')
-rw-r--r--partners_api/downloader_promo.cpp10
-rw-r--r--partners_api/downloader_promo.hpp44
2 files changed, 26 insertions, 28 deletions
diff --git a/partners_api/downloader_promo.cpp b/partners_api/downloader_promo.cpp
index ebfb06f170..df887e7208 100644
--- a/partners_api/downloader_promo.cpp
+++ b/partners_api/downloader_promo.cpp
@@ -5,13 +5,13 @@
namespace promo
{
// static
-DownloaderPromoBanner DownloaderPromo::GetBanner(storage::Storage const & storage,
- std::string const & mwmId,
- std::string const & currentLocale,
- bool hasRemoveAdsSubscription)
+DownloaderPromo::Banner DownloaderPromo::GetBanner(storage::Storage const & storage,
+ std::string const & mwmId,
+ std::string const & currentLocale,
+ bool hasRemoveAdsSubscription)
{
if (!hasRemoveAdsSubscription && ads::HasMegafonDownloaderBanner(storage, mwmId, currentLocale))
- return {DownloaderPromoType::Megafon, ads::GetMegafonDownloaderBannerUrl()};
+ return {DownloaderPromo::Type::Megafon, ads::GetMegafonDownloaderBannerUrl()};
// TODO: add bookmark catalog banner.
diff --git a/partners_api/downloader_promo.hpp b/partners_api/downloader_promo.hpp
index 7bbb2605d0..74d680bfcb 100644
--- a/partners_api/downloader_promo.hpp
+++ b/partners_api/downloader_promo.hpp
@@ -7,32 +7,30 @@
namespace promo
{
-// Do not change the order.
-enum class DownloaderPromoType : uint8_t
+class DownloaderPromo
{
- NoPromo = 0,
- BookmarkCatalog = 1,
- Megafon = 2
-};
+public:
+ // Do not change the order.
+ enum class Type : uint8_t
+ {
+ NoPromo = 0,
+ BookmarkCatalog = 1,
+ Megafon = 2
+ };
-struct DownloaderPromoBanner
-{
- DownloaderPromoBanner() = default;
- DownloaderPromoBanner(DownloaderPromoType type, std::string const & url)
- : m_type(type)
- , m_url(url)
- {}
+ struct Banner
+ {
+ Banner() = default;
+ Banner(Type type, std::string const & url)
+ : m_type(type)
+ , m_url(url)
+ {}
- DownloaderPromoType m_type = DownloaderPromoType::NoPromo;
- std::string m_url;
-};
+ Type m_type = Type::NoPromo;
+ std::string m_url;
+ };
-class DownloaderPromo
-{
-public:
- static DownloaderPromoBanner GetBanner(storage::Storage const & storage,
- std::string const & mwmId,
- std::string const & currentLocale,
- bool hasRemoveAdsSubscription);
+ static Banner GetBanner(storage::Storage const & storage, std::string const & mwmId,
+ std::string const & currentLocale, bool hasRemoveAdsSubscription);
};
} // namespace promo