diff options
author | Maxim Pimenov <m@maps.me> | 2019-04-15 16:19:43 +0300 |
---|---|---|
committer | Tatiana Yan <tatiana.kondakova@gmail.com> | 2019-04-15 16:47:25 +0300 |
commit | 25087ac0bf7e8c41e0d0684e43b5285a8b8be47c (patch) | |
tree | 037bf60263dd28a5ec4b16be01b96f927b44a963 /search | |
parent | 939e41450aa9c13117c1e1a6cc516b11f8bed8aa (diff) |
Review fixes.
Diffstat (limited to 'search')
-rw-r--r-- | search/search_quality/assessment_tool/edits.hpp | 2 | ||||
-rw-r--r-- | search/search_quality/sample.hpp | 11 |
2 files changed, 11 insertions, 2 deletions
diff --git a/search/search_quality/assessment_tool/edits.hpp b/search/search_quality/assessment_tool/edits.hpp index eeefd72749..2bc55da509 100644 --- a/search/search_quality/assessment_tool/edits.hpp +++ b/search/search_quality/assessment_tool/edits.hpp @@ -16,7 +16,7 @@ struct SampleEdits { using OnUpdate = std::function<void()>; - SampleEdits(OnUpdate onUpdate) : m_onUpdate(onUpdate) {} + explicit SampleEdits(OnUpdate onUpdate) : m_onUpdate(onUpdate) {} void Reset(bool origUseless); void FlipUsefulness(); diff --git a/search/search_quality/sample.hpp b/search/search_quality/sample.hpp index a66340b67a..6a19942549 100644 --- a/search/search_quality/sample.hpp +++ b/search/search_quality/sample.hpp @@ -81,7 +81,16 @@ struct Sample // the search engine without a clear search intent or a sample // that cannot be assessed properly using only the data available // to the engine (for example, related queries may help a lot but - // are not expected to be available). + // are not expected to be available, or local knowledge of the area + // is needed). + // More examples: + // * A sample whose requests is precisely about a particular street + // in a particular city is useless if the assessor is sure that + // there is no such street in this city. + // * On the other hand, if there is such a street (or, more often, + // a building) as indicated by other data sources but the engine + // still could not find it because of its absense in our + // data, the sample is NOT useless. bool m_useless = false; }; |