Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/mapsme/omim.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMaxim Pimenov <m@maps.me>2017-09-26 12:21:45 +0300
committerIlya Zverev <ilya@zverev.info>2017-09-26 14:07:51 +0300
commit8a20512b77c6a022f45bc585373e981d71a727ea (patch)
tree787699f3b2f4442b51e8b63931ce79b78ee6dea4 /storage
parent075e48325e2b58dad239cd315ae7f187029d7254 (diff)
[platform] Fixed warnings in MkDir.
Diffstat (limited to 'storage')
-rw-r--r--storage/storage.cpp8
-rw-r--r--storage/storage_tests/storage_tests.cpp7
2 files changed, 9 insertions, 6 deletions
diff --git a/storage/storage.cpp b/storage/storage.cpp
index 4956578fe8..8c2aa0b662 100644
--- a/storage/storage.cpp
+++ b/storage/storage.cpp
@@ -15,6 +15,7 @@
#include "coding/reader.hpp"
#include "coding/url_encode.hpp"
+#include "base/exception.hpp"
#include "base/gmtime.hpp"
#include "base/logging.hpp"
#include "base/scope_guard.hpp"
@@ -655,8 +656,11 @@ void Storage::LoadCountriesFile(string const & pathToCountriesFile, string const
{
m_dataDir = dataDir;
- if (!m_dataDir.empty())
- Platform::MkDir(my::JoinFoldersToPath(GetPlatform().WritableDir(), m_dataDir));
+ if (!m_dataDir.empty() &&
+ !Platform::MkDirChecked(my::JoinFoldersToPath(GetPlatform().WritableDir(), m_dataDir)))
+ {
+ MYTHROW(FileSystemException, ("Unable to find or create directory", m_dataDir));
+ }
if (m_countries.IsEmpty())
{
diff --git a/storage/storage_tests/storage_tests.cpp b/storage/storage_tests/storage_tests.cpp
index 645e81aa12..8e24bc17f6 100644
--- a/storage/storage_tests/storage_tests.cpp
+++ b/storage/storage_tests/storage_tests.cpp
@@ -38,6 +38,7 @@
#include "defines.hpp"
+#include "base/assert.hpp"
#include "base/scope_guard.hpp"
#include "base/string_utils.hpp"
@@ -1380,10 +1381,8 @@ UNIT_TEST(StorageTest_GetUpdateInfoSingleMwm)
classificator::Load();
WritableDirChanger writableDirChanger(kMapTestDir);
- Platform & platform = GetPlatform();
-
- string const kVersion1Dir = my::JoinFoldersToPath(platform.WritableDir(), "1");
- platform.MkDir(kVersion1Dir);
+ string const kVersion1Dir = my::JoinFoldersToPath(GetPlatform().WritableDir(), "1");
+ CHECK_EQUAL(Platform::MkDir(kVersion1Dir), Platform::ERR_OK, ());
LocalCountryFile country1(kVersion1Dir, CountryFile("OutdatedCountry1"), 1);
LocalCountryFile country2(kVersion1Dir, CountryFile("OutdatedCountry2"), 1);