1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
|
#include "indexer/classificator.hpp"
#include "indexer/feature.hpp"
#include "indexer/classificator.hpp"
#include "indexer/feature_algo.hpp"
#include "indexer/feature_impl.hpp"
#include "indexer/feature_loader_base.hpp"
#include "indexer/feature_visibility.hpp"
#include "indexer/osm_editor.hpp"
#include "geometry/distance.hpp"
#include "geometry/robust_orientation.hpp"
#include "platform/preferred_languages.hpp"
#include "base/range_iterator.hpp"
#include "base/stl_helpers.hpp"
#include "std/algorithm.hpp"
using namespace feature;
///////////////////////////////////////////////////////////////////////////////////////////////////
// FeatureBase implementation
///////////////////////////////////////////////////////////////////////////////////////////////////
void FeatureBase::Deserialize(feature::LoaderBase * pLoader, TBuffer buffer)
{
m_pLoader = pLoader;
m_pLoader->Init(buffer);
m_limitRect = m2::RectD::GetEmptyRect();
m_bTypesParsed = m_bCommonParsed = false;
m_header = m_pLoader->GetHeader();
}
void FeatureType::ApplyPatch(editor::XMLFeature const & xml)
{
xml.ForEachName([this](string const & lang, string const & name)
{
m_params.name.AddString(lang, name);
});
string const house = xml.GetHouse();
if (!house.empty())
m_params.house.Set(house);
// TODO(mgsergio):
// m_params.ref =
// m_params.layer =
// m_params.rank =
m_bCommonParsed = true;
xml.ForEachTag([this](string const & k, string const & v)
{
Metadata::EType mdType;
if (Metadata::TypeFromString(k, mdType))
m_metadata.Set(mdType, v);
else
LOG(LWARNING, ("Patching feature has unknown tags"));
});
m_metadataParsed = true;
// If types count are changed here, in ApplyPatch, new number of types should be passed
// instead of GetTypesCount().
m_header = CalculateHeader(GetTypesCount(), Header() & HEADER_GEOTYPE_MASK, m_params);
m_header2Parsed = true;
}
void FeatureType::ReplaceBy(osm::EditableMapObject const & emo)
{
uint8_t geoType;
if (emo.IsPointType())
{
// We are here for existing point features and for newly created point features.
m_center = emo.GetMercator();
m_limitRect.MakeEmpty();
m_limitRect.Add(m_center);
m_pointsParsed = m_trianglesParsed = true;
geoType = feature::GEOM_POINT;
}
else
{
geoType = Header() & HEADER_GEOTYPE_MASK;
}
m_params.name = emo.GetName();
string const & house = emo.GetHouseNumber();
if (house.empty())
m_params.house.Clear();
else
m_params.house.Set(house);
m_bCommonParsed = true;
m_metadata = emo.GetMetadata();
m_metadataParsed = true;
uint32_t typesCount = 0;
for (uint32_t const type : emo.GetTypes())
m_types[typesCount++] = type;
m_bTypesParsed = true;
m_header = CalculateHeader(typesCount, geoType, m_params);
m_header2Parsed = true;
m_id = emo.GetID();
}
editor::XMLFeature FeatureType::ToXML(bool serializeType) const
{
editor::XMLFeature feature(GetFeatureType() == feature::GEOM_POINT
? editor::XMLFeature::Type::Node
: editor::XMLFeature::Type::Way);
if (GetFeatureType() == feature::GEOM_POINT)
{
feature.SetCenter(GetCenter());
}
else
{
ParseTriangles(BEST_GEOMETRY);
vector<m2::PointD> geometry(begin(m_triangles), end(m_triangles));
// Remove duplicates.
my::SortUnique(geometry);
feature.SetGeometry(geometry);
}
ForEachName([&feature](uint8_t const & lang, string const & name)
{
feature.SetName(lang, name);
return true;
});
string const house = GetHouseNumber();
if (!house.empty())
feature.SetHouse(house);
// TODO(mgsergio):
// feature.m_params.ref =
// feature.m_params.layer =
// feature.m_params.rank =
if (serializeType)
{
feature::TypesHolder th(*this);
// TODO(mgsergio): Use correct sorting instead of SortBySpec based on the config.
th.SortBySpec();
Classificator & cl = classif();
static const uint32_t internetType = cl.GetTypeByPath({"internet_access"});
// TODO(mgsergio): Either improve "OSM"-compatible serialization for more complex types,
// or save all our types directly, to restore and reuse them in migration of modified features.
for (uint32_t const type : th)
{
{ // Avoid serialization of "internet" type, it is set separately in the Editor.
// Otherwise we can't reset "internet" to "Unknown" state.
uint32_t truncatedType = type;
ftype::TruncValue(truncatedType, 1);
if (truncatedType == internetType)
continue;
}
string const strType = cl.GetReadableObjectName(type);
strings::SimpleTokenizer iter(strType, "-");
string const k = *iter;
if (++iter)
{
// First (main) type is always stored as "k=amenity v=restaurant".
// Any other "k=amenity v=atm" is replaced by "k=atm v=yes".
if (feature.GetTagValue(k).empty())
feature.SetTagValue(k, *iter);
else
feature.SetTagValue(*iter, "yes");
}
else
{
// We're editing building, generic craft, shop, office, amenity etc.
// Skip it's serialization.
// TODO(mgsergio): Correcly serialize all types back and forth.
LOG(LDEBUG, ("Skipping type serialization:", k));
}
}
}
for (auto const type : m_metadata.GetPresentTypes())
{
auto const attributeName = DebugPrint(static_cast<Metadata::EType>(type));
feature.SetTagValue(attributeName, m_metadata.Get(type));
}
return feature;
}
bool FeatureType::FromXML(editor::XMLFeature const & xml)
{
ASSERT_EQUAL(editor::XMLFeature::Type::Node, xml.GetType(),
("At the moment only new nodes (points) can can be created."));
m_center = xml.GetMercatorCenter();
m_limitRect.Add(m_center);
m_pointsParsed = m_trianglesParsed = true;
xml.ForEachName([this](string const & lang, string const & name)
{
m_params.name.AddString(lang, name);
});
string const house = xml.GetHouse();
if (!house.empty())
m_params.house.Set(house);
// TODO(mgsergio):
// m_params.ref =
// m_params.layer =
// m_params.rank =
m_bCommonParsed = true;
uint32_t typesCount = 0;
xml.ForEachTag([this, &typesCount](string const & k, string const & v)
{
Metadata::EType mdType;
if (Metadata::TypeFromString(k, mdType))
{
m_metadata.Set(mdType, v);
}
else
{
// Simple heuristics. It works if all our supported types for new features at data/editor.config
// are of one or two levels nesting (currently it's true).
Classificator & cl = classif();
uint32_t type = cl.GetTypeByPathSafe({k, v});
if (type == 0)
type = cl.GetTypeByPathSafe({k}); // building etc.
if (type == 0)
type = cl.GetTypeByPathSafe({"amenity", k}); // atm=yes, toilet=yes etc.
if (type)
m_types[typesCount++] = type;
else
LOG(LWARNING, ("Can't load/parse type:", k, v));
}
});
m_metadataParsed = true;
m_bTypesParsed = true;
EHeaderTypeMask const geomType = house.empty() && !m_params.ref.empty() ? HEADER_GEOM_POINT : HEADER_GEOM_POINT_EX;
m_header = CalculateHeader(typesCount, geomType, m_params);
m_header2Parsed = true;
return typesCount > 0;
}
void FeatureBase::ParseTypes() const
{
if (!m_bTypesParsed)
{
m_pLoader->ParseTypes();
m_bTypesParsed = true;
}
}
void FeatureBase::ParseCommon() const
{
if (!m_bCommonParsed)
{
ParseTypes();
m_pLoader->ParseCommon();
m_bCommonParsed = true;
}
}
feature::EGeomType FeatureBase::GetFeatureType() const
{
switch (Header() & HEADER_GEOTYPE_MASK)
{
case HEADER_GEOM_LINE: return GEOM_LINE;
case HEADER_GEOM_AREA: return GEOM_AREA;
default: return GEOM_POINT;
}
}
string FeatureBase::DebugString() const
{
ParseCommon();
Classificator const & c = classif();
string res = "Types";
for (size_t i = 0; i < GetTypesCount(); ++i)
res += (" : " + c.GetReadableObjectName(m_types[i]));
res += "\n";
return (res + m_params.DebugString());
}
///////////////////////////////////////////////////////////////////////////////////////////////////
// FeatureType implementation
///////////////////////////////////////////////////////////////////////////////////////////////////
void FeatureType::Deserialize(feature::LoaderBase * pLoader, TBuffer buffer)
{
base_type::Deserialize(pLoader, buffer);
m_pLoader->InitFeature(this);
m_header2Parsed = m_pointsParsed = m_trianglesParsed = m_metadataParsed = false;
m_innerStats.MakeZero();
}
void FeatureType::ParseEverything() const
{
// Also calls ParseCommon() and ParseTypes().
ParseHeader2();
ParseGeometry(FeatureType::BEST_GEOMETRY);
ParseTriangles(FeatureType::BEST_GEOMETRY);
ParseMetadata();
}
void FeatureType::ParseHeader2() const
{
if (!m_header2Parsed)
{
ParseCommon();
m_pLoader->ParseHeader2();
m_header2Parsed = true;
}
}
void FeatureType::ResetGeometry() const
{
m_points.clear();
m_triangles.clear();
if (GetFeatureType() != GEOM_POINT)
m_limitRect = m2::RectD();
m_header2Parsed = m_pointsParsed = m_trianglesParsed = false;
m_pLoader->ResetGeometry();
}
uint32_t FeatureType::ParseGeometry(int scale) const
{
uint32_t sz = 0;
if (!m_pointsParsed)
{
ParseHeader2();
sz = m_pLoader->ParseGeometry(scale);
m_pointsParsed = true;
}
return sz;
}
uint32_t FeatureType::ParseTriangles(int scale) const
{
uint32_t sz = 0;
if (!m_trianglesParsed)
{
ParseHeader2();
sz = m_pLoader->ParseTriangles(scale);
m_trianglesParsed = true;
}
return sz;
}
void FeatureType::ParseMetadata() const
{
if (m_metadataParsed) return;
m_pLoader->ParseMetadata();
m_metadataParsed = true;
}
StringUtf8Multilang const & FeatureType::GetNames() const
{
return m_params.name;
}
void FeatureType::SetNames(StringUtf8Multilang const & newNames)
{
m_params.name.Clear();
// Validate passed string to clean up empty names (if any).
newNames.ForEach([this](int8_t langCode, string const & name) -> bool
{
if (!name.empty())
m_params.name.AddString(langCode, name);
return true;
});
if (m_params.name.IsEmpty())
SetHeader(~feature::HEADER_HAS_NAME & Header());
else
SetHeader(feature::HEADER_HAS_NAME | Header());
}
void FeatureType::SetMetadata(feature::Metadata const & newMetadata)
{
m_metadataParsed = true;
m_metadata = newMetadata;
}
namespace
{
template <class TCont>
void Points2String(string & s, TCont const & points)
{
for (size_t i = 0; i < points.size(); ++i)
s += DebugPrint(points[i]) + " ";
}
}
string FeatureType::DebugString(int scale) const
{
ParseGeometryAndTriangles(scale);
string s = base_type::DebugString();
switch (GetFeatureType())
{
case GEOM_POINT:
s += (" Center:" + DebugPrint(m_center));
break;
case GEOM_LINE:
s += " Points:";
Points2String(s, m_points);
break;
case GEOM_AREA:
s += " Triangles:";
Points2String(s, m_triangles);
break;
case GEOM_UNDEFINED:
ASSERT(false, ("Assume that we have valid feature always"));
break;
}
return s;
}
string DebugPrint(FeatureType const & ft)
{
return ft.DebugString(FeatureType::BEST_GEOMETRY);
}
bool FeatureType::IsEmptyGeometry(int scale) const
{
ParseGeometryAndTriangles(scale);
switch (GetFeatureType())
{
case GEOM_AREA: return m_triangles.empty();
case GEOM_LINE: return m_points.empty();
default: return false;
}
}
m2::RectD FeatureType::GetLimitRect(int scale) const
{
ParseGeometryAndTriangles(scale);
if (m_triangles.empty() && m_points.empty() && (GetFeatureType() != GEOM_POINT))
{
// This function is called during indexing, when we need
// to check visibility according to feature sizes.
// So, if no geometry for this scale, assume that rect has zero dimensions.
m_limitRect = m2::RectD(0, 0, 0, 0);
}
return m_limitRect;
}
void FeatureType::ParseGeometryAndTriangles(int scale) const
{
ParseGeometry(scale);
ParseTriangles(scale);
}
FeatureType::geom_stat_t FeatureType::GetGeometrySize(int scale) const
{
uint32_t sz = ParseGeometry(scale);
if (sz == 0 && !m_points.empty())
sz = m_innerStats.m_points;
return geom_stat_t(sz, m_points.size());
}
FeatureType::geom_stat_t FeatureType::GetTrianglesSize(int scale) const
{
uint32_t sz = ParseTriangles(scale);
if (sz == 0 && !m_triangles.empty())
sz = m_innerStats.m_strips;
return geom_stat_t(sz, m_triangles.size());
}
struct BestMatchedLangNames
{
string m_defaultName;
string m_nativeName;
string m_intName;
string m_englishName;
bool operator()(int8_t code, string const & name)
{
int8_t const defaultCode = StringUtf8Multilang::kDefaultCode;
static int8_t const nativeCode = StringUtf8Multilang::GetLangIndex(languages::GetCurrentNorm());
int8_t const intCode = StringUtf8Multilang::kInternationalCode;
int8_t const englishCode = StringUtf8Multilang::kEnglishCode;
if (code == defaultCode)
m_defaultName = name;
else if (code == nativeCode)
m_nativeName = name;
else if (code == intCode)
{
// There are many "junk" names in Arabian island.
m_intName = name.substr(0, name.find_first_of(','));
// int_name should be used as name:en when name:en not found
if ((nativeCode == englishCode) && m_nativeName.empty())
m_nativeName = m_intName;
}
else if (code == englishCode)
m_englishName = name;
return true;
}
};
void FeatureType::GetPreferredNames(string & defaultName, string & intName) const
{
ParseCommon();
BestMatchedLangNames matcher;
ForEachName(matcher);
defaultName.swap(matcher.m_defaultName);
if (!matcher.m_nativeName.empty())
intName.swap(matcher.m_nativeName);
else if (!matcher.m_intName.empty())
intName.swap(matcher.m_intName);
else
intName.swap(matcher.m_englishName);
if (defaultName.empty())
defaultName.swap(intName);
else
{
// filter out similar intName
if (!intName.empty() && defaultName.find(intName) != string::npos)
intName.clear();
}
}
void FeatureType::GetReadableName(string & name) const
{
ParseCommon();
BestMatchedLangNames matcher;
ForEachName(matcher);
if (!matcher.m_nativeName.empty())
name.swap(matcher.m_nativeName);
else if (!matcher.m_defaultName.empty())
name.swap(matcher.m_defaultName);
else if (!matcher.m_intName.empty())
name.swap(matcher.m_intName);
else
name.swap(matcher.m_englishName);
}
string FeatureType::GetHouseNumber() const
{
ParseCommon();
return m_params.house.Get();
}
void FeatureType::SetHouseNumber(string const & number)
{
if (number.empty())
m_params.house.Clear();
else
m_params.house.Set(number);
}
bool FeatureType::GetName(int8_t lang, string & name) const
{
if (!HasName())
return false;
ParseCommon();
return m_params.name.GetString(lang, name);
}
uint8_t FeatureType::GetRank() const
{
ParseCommon();
return m_params.rank;
}
uint32_t FeatureType::GetPopulation() const
{
return feature::RankToPopulation(GetRank());
}
string FeatureType::GetRoadNumber() const
{
ParseCommon();
return m_params.ref;
}
void FeatureType::SwapGeometry(FeatureType & r)
{
ASSERT_EQUAL(m_pointsParsed, r.m_pointsParsed, ());
ASSERT_EQUAL(m_trianglesParsed, r.m_trianglesParsed, ());
if (m_pointsParsed)
m_points.swap(r.m_points);
if (m_trianglesParsed)
m_triangles.swap(r.m_triangles);
}
|