diff options
| author | Abhishek Aggarwal <aaggarwal@mozilla.com> | 2020-12-01 13:36:11 +0300 |
|---|---|---|
| committer | Abhishek Aggarwal <aaggarwal@mozilla.com> | 2020-12-01 13:36:11 +0300 |
| commit | a01874186703025369b72479181a0d34c47cd93c (patch) | |
| tree | 6166e412b575541e38b0f932917af0b2a2fdaa87 | |
| parent | ed081ba03efb2826a082038404d10b044a45f27e (diff) | |
WASM compilation: Disable Pthreads + memory growth warning to be an error
- Pthreads + memory growth causes JS accessing the wasm memory to be slow
https://github.com/WebAssembly/design/issues/1271
- Leave this as a warning rather than making it a compilation error
| -rw-r--r-- | CMakeLists.txt | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/CMakeLists.txt b/CMakeLists.txt index 67f18ef..9089827 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -14,6 +14,12 @@ if(MSVC) add_compile_options(/W4 /WX) else() add_compile_options(-Wall -Wextra -pedantic -Werror -Wno-unknown-pragmas) + if (COMPILE_WASM) + # Disabling Pthreads + memory growth warning to be an error for WASM + # Pthreads + memory growth causes JS accessing the wasm memory to be slow + # https://github.com/WebAssembly/design/issues/1271 + add_compile_options(-Wno-error=pthreads-mem-growth) + endif() endif() # Check if compiler supports AVX2 (this should only catch emscripten) |