fix: change description for segments visitEndServer* (#15518) (#15993)

4 files changed, 30 insertions, 33 deletions

diff --git a/plugins/CoreHome/Columns/VisitLastActionMinute.php b/plugins/CoreHome/Columns/VisitLastActionMinute.php
index a5c284d0e1..b3b50fbd52 100644
--- a/plugins/CoreHome/Columns/VisitLastActionMinute.php
+++ b/plugins/CoreHome/Columns/VisitLastActionMinute.php
@@ -16,12 +16,9 @@ use Piwik\Metrics\Formatter;
 require_once PIWIK_INCLUDE_PATH . '/plugins/VisitTime/functions.php';
 
 /**
- * This dimension holds the best guess for a visit's end time. It is set the last action
- * time for each visit. `ping=1` requests can be sent to update the dimension value so
- * it can be a more accurate guess of the time the visitor spent on the site.
+ * This dimension holds visit's last action time in a visit.
  *
- * Note: though it is named 'visit last action time' it actually refers to the visit's last action's
- * end time.
+ * Note: though it is named 'visit end time time' it actually refers to the visit's last action.
  */
 class VisitLastActionMinute extends VisitDimension
 {
diff --git a/plugins/CustomDimensions b/plugins/CustomDimensions
-Subproject 10665789dc16cf7bef9513891df4c6fd1353352
+Subproject 920cb6a38fb652308e0a044d284a05b4372aedf
diff --git a/plugins/VisitTime/lang/en.json b/plugins/VisitTime/lang/en.json
index 36aefd4217..6ab07b2c31 100644
--- a/plugins/VisitTime/lang/en.json
+++ b/plugins/VisitTime/lang/en.json
@@ -5,19 +5,19 @@
         "ColumnLocalMinute": "Local time - minute (Start of visit)",
         "ColumnServerTime": "Server time",
         "ColumnServerHour": "Server time - hour",
-        "ColumnVisitEndServerHour": "Server time - hour (End of visit)",
-        "ColumnVisitEndServerMinute": "Server time - minute (End of visit)",
+        "ColumnVisitEndServerHour": "Server time - hour (Time of last action)",
+        "ColumnVisitEndServerMinute": "Server time - minute (Time of last action)",
         "ColumnVisitStartServerHour": "Server time - hour (Start of visit)",
         "ColumnVisitStartServerMinute": "Server time - minute (Start of visit)",
-        "ColumnVisitEndServerDate": "Server time - date (End of visit)",
-        "ColumnVisitEndServerDayOfMonth": "Server time - day of month (End of visit)",
-        "ColumnVisitEndServerDayOfWeek": "Server time - day of week (End of visit)",
-        "ColumnVisitEndServerDayOfYear": "Server time - day of year (End of visit)",
-        "ColumnVisitEndServerQuarter": "Server time - quarter (End of visit)",
-        "ColumnVisitEndServerSecond": "Server time - second (End of visit)",
-        "ColumnVisitEndServerWeekOfYear": "Server time - week of year (End of visit)",
-        "ColumnVisitEndServerMonth": "Server time - month (End of visit)",
-        "ColumnVisitEndServerYear": "Server time - year (End of visit)",
+        "ColumnVisitEndServerDate": "Server time - date (Time of last action)",
+        "ColumnVisitEndServerDayOfMonth": "Server time - day of month (Time of last action)",
+        "ColumnVisitEndServerDayOfWeek": "Server time - day of week (Time of last action)",
+        "ColumnVisitEndServerDayOfYear": "Server time - day of year (Time of last action)",
+        "ColumnVisitEndServerQuarter": "Server time - quarter (Time of last action)",
+        "ColumnVisitEndServerSecond": "Server time - second (Time of last action)",
+        "ColumnVisitEndServerWeekOfYear": "Server time - week of year (Time of last action)",
+        "ColumnVisitEndServerMonth": "Server time - month (Time of last action)",
+        "ColumnVisitEndServerYear": "Server time - year (Time of last action)",
         "ColumnServerMinute": "Server time - minute",
         "DayOfWeek": "Day of the week",
         "LocalTime": "Visits per local time",
diff --git a/tests/PHPUnit/System/expected/test_apiGetReportMetadata__API.getSegmentsMetadata.xml b/tests/PHPUnit/System/expected/test_apiGetReportMetadata__API.getSegmentsMetadata.xml
index d0776af521..7d0c3a4557 100644
--- a/tests/PHPUnit/System/expected/test_apiGetReportMetadata__API.getSegmentsMetadata.xml
+++ b/tests/PHPUnit/System/expected/test_apiGetReportMetadata__API.getSegmentsMetadata.xml
@@ -168,91 +168,91 @@
 	<row>
 		<type>dimension</type>
 		<category>Visitors</category>
-		<name>Server time - date (End of visit)</name>
+		<name>Server time - date (Time of last action)</name>
 		<segment>visitEndServerDate</segment>
 		<acceptedValues>2018-12-31, 2018-03-20, ...</acceptedValues>
 	</row>
 	<row>
 		<type>dimension</type>
 		<category>Visitors</category>
-		<name>Server time - day of month (End of visit)</name>
+		<name>Server time - day of month (Time of last action)</name>
 		<segment>visitEndServerDayOfMonth</segment>
 		<acceptedValues>0, 1, 2, 3, ..., 29, 30, 31</acceptedValues>
 	</row>
 	<row>
 		<type>dimension</type>
 		<category>Visitors</category>
-		<name>Server time - day of week (End of visit)</name>
+		<name>Server time - day of week (Time of last action)</name>
 		<segment>visitEndServerDayOfWeek</segment>
 		<acceptedValues>1, 2, 3, 4, 5, 6, 7</acceptedValues>
 	</row>
 	<row>
 		<type>dimension</type>
 		<category>Visitors</category>
-		<name>Server time - day of year (End of visit)</name>
+		<name>Server time - day of year (Time of last action)</name>
 		<segment>visitEndServerDayOfYear</segment>
 		<acceptedValues>1, 2, 3, 4, ..., 365, 366</acceptedValues>
 	</row>
 	<row>
 		<type>dimension</type>
 		<category>Visitors</category>
-		<name>Server time - hour (End of visit)</name>
-		<segment>visitServerHour</segment>
+		<name>Server time - hour (Start of visit)</name>
+		<segment>visitStartServerHour</segment>
 		<acceptedValues>0, 1, 2, 3, ..., 20, 21, 22, 23</acceptedValues>
 	</row>
 	<row>
 		<type>dimension</type>
 		<category>Visitors</category>
-		<name>Server time - hour (Start of visit)</name>
-		<segment>visitStartServerHour</segment>
+		<name>Server time - hour (Time of last action)</name>
+		<segment>visitServerHour</segment>
 		<acceptedValues>0, 1, 2, 3, ..., 20, 21, 22, 23</acceptedValues>
 	</row>
 	<row>
 		<type>dimension</type>
 		<category>Visitors</category>
-		<name>Server time - minute (End of visit)</name>
-		<segment>visitEndServerMinute</segment>
+		<name>Server time - minute (Start of visit)</name>
+		<segment>visitStartServerMinute</segment>
 		<acceptedValues>0, 1, 2, 3, ..., 56, 57, 58, 59</acceptedValues>
 	</row>
 	<row>
 		<type>dimension</type>
 		<category>Visitors</category>
-		<name>Server time - minute (Start of visit)</name>
-		<segment>visitStartServerMinute</segment>
+		<name>Server time - minute (Time of last action)</name>
+		<segment>visitEndServerMinute</segment>
 		<acceptedValues>0, 1, 2, 3, ..., 56, 57, 58, 59</acceptedValues>
 	</row>
 	<row>
 		<type>dimension</type>
 		<category>Visitors</category>
-		<name>Server time - month (End of visit)</name>
+		<name>Server time - month (Time of last action)</name>
 		<segment>visitEndServerMonth</segment>
 		<acceptedValues>1, 2, 3, ..., 11, 12</acceptedValues>
 	</row>
 	<row>
 		<type>dimension</type>
 		<category>Visitors</category>
-		<name>Server time - quarter (End of visit)</name>
+		<name>Server time - quarter (Time of last action)</name>
 		<segment>visitEndServerQuarter</segment>
 		<acceptedValues>1, 2, 3, 4</acceptedValues>
 	</row>
 	<row>
 		<type>dimension</type>
 		<category>Visitors</category>
-		<name>Server time - second (End of visit)</name>
+		<name>Server time - second (Time of last action)</name>
 		<segment>visitEndServerSecond</segment>
 		<acceptedValues>0, 1, 2, 3, ..., 58, 59</acceptedValues>
 	</row>
 	<row>
 		<type>dimension</type>
 		<category>Visitors</category>
-		<name>Server time - week of year (End of visit)</name>
+		<name>Server time - week of year (Time of last action)</name>
 		<segment>visitEndServerWeekOfYear</segment>
 		<acceptedValues>1, 2, 3, 4, ..., 51, 52, 53</acceptedValues>
 	</row>
 	<row>
 		<type>dimension</type>
 		<category>Visitors</category>
-		<name>Server time - year (End of visit)</name>
+		<name>Server time - year (Time of last action)</name>
 		<segment>visitEndServerYear</segment>
 		<acceptedValues>2016, 2017, 2018, ..., 9998, 9999</acceptedValues>
 	</row>